Change Details

{icon calendar} | Friday, 24th June 2016 - 15:30 UTC {icon user} | jayvdb, legoktm, darthbhyrava **Skype** **Description**: Final Weekly Meeting before the Mid-Term Evaluation *** === Agenda: - Review patch for T135409 : [[ https://gerrit.wikimedia.org/r/#/c/294901/ | 294901 ]]. - Review patch for T135411: [[ https://gerrit.wikimedia.org/r/#/c/295132/ | 295132 ]]. - Determine necessary changes so that the patches pass with `+2` from `jenkins`. - Other requirements for passing Mid-Term Evaluations: [x] Submitting the Evaluation Form [x] Updating Weekly Reports - T133667 [ ] Changes pushed to local GitHub repository. Changes made since last meet : ===== Subtask I [x] Use the Revision class instead of a recursive function to get revision details in `thanks.py`. [x] Remove the hack and let `User.thanks_enabled` do the job in `thanks_tests.py`. [x] Improve the assertion in unit test scripts to make it more precise and meaningful. [x] Shift to variable `revid` consistently throughout. [x] Add source as a user customisable parameter to def `get_revision()` in site.py [x] Shift the above method in site.py next to the other revision methods. [x] Shift `thanks.py` to maintenance folder. [x] Adhere to coding linting rules. [x] Remove `u""` since we're using unicode literals. [x] `thank_rev` should take APISite as a parameter. [x] If `user.thanks_enabled=False`, then what? [x] If user doesn't specify arguments, then what? [x] Use self.assertRaises to check for exceptions thrown for bad data. Account for as many as possible. [x] Change name of unit test class to a non-abbreviated one. [x] Improve implementation of getting Site object. [ ] Add tests for new site.py method. //What class, what to assert?// [ ] Add `write=True` to thanks_tests as per tests/README // Tests fail, ask me to add PYWIKIBOT2_TEST_WRITE=1// [ ] Make direct calls to page.py and site.py for unit test. //On hold - what are we testing, then?// ===== Subtask II [ ] Look into and document all errors caused by `sort_by='updated'` param in `flow_thanks_tests.py`. [ ] Get a suitable workaround for the bug in `flow_thanks_tests.py`, and document the bug. [ ] Improve the assertion in unit test scripts to make it more precise and meaningful. [ ] Use ordinary slice instead of islice() [ ] Add tests for new site.py method. [ ] Shift `flow_thanks.py` to maintenance folder. [ ] Adhere to coding linting rules. [ ] Remove `u""` since we're using unicode literals. [ ] `thank_flowpost` should take APISite as a parameter. [ ] If `user.thanks_enabled=False`, then what? [ ] Improve implementation of getting Site object. [ ] If user doesn't specify arguments, then what? [ ] Use self.assertRaises to check for exceptions thrown for bad data. Account for as many as possible. [ ] Remove the list post_ids[] and rename it appropriately. [ ] Add tests for new site.py method. [ ] Add tests for border cases.

{icon calendar} | Friday, 24th June 2016 - 15:30 UTC {icon user} | jayvdb, legoktm, darthbhyrava **Skype** **Description**: Final Weekly Meeting before the Mid-Term Evaluation *** === Agenda: - Review patch for T135409 : [[ https://gerrit.wikimedia.org/r/#/c/294901/ | 294901 ]]. - Review patch for T135411: [[ https://gerrit.wikimedia.org/r/#/c/295132/ | 295132 ]]. - Determine necessary changes so that the patches pass with `+2` from `jenkins`. - Other requirements for passing Mid-Term Evaluations: [x] Submitting the Evaluation Form [x] Updating Weekly Reports - T133667 [ ] Changes pushed to local GitHub repository. Changes made since last meet : ===== Subtask I [x] Use the Revision class instead of a recursive function to get revision details in `thanks.py`. [x] Remove the hack and let `User.thanks_enabled` do the job in `thanks_tests.py`. [x] Improve the assertion in unit test scripts to make it more precise and meaningful. [x] Shift to variable `revid` consistently throughout. [x] Add source as a user customisable parameter to def `get_revision()` in site.py [x] Shift the above method in site.py next to the other revision methods. [x] Shift `thanks.py` to maintenance folder. [x] Adhere to coding linting rules. [x] Remove `u""` since we're using unicode literals. [x] `thank_rev` should take APISite as a parameter. [x] If `user.thanks_enabled=False`, then what? [x] If user doesn't specify arguments, then what? [x] Use self.assertRaises to check for exceptions thrown for bad data. Account for as many as possible. [x] Change name of unit test class to a non-abbreviated one. [x] Improve implementation of getting Site object. [ ] Add tests for new site.py method. //What class, what to assert?// [ ] Add `write=True` to thanks_tests as per tests/README // Tests fail, ask me to add PYWIKIBOT2_TEST_WRITE=1// [ ] Make direct calls to page.py and site.py for unit test. //On hold - what are we testing, then?// ===== Subtask II [x] Look into and document all errors caused by `sort_by='updated'` param in `flow_thanks_tests.py`. - jayvdb got to it before me: please look at T138323, T138215, T138307, T138306. [x] Get a suitable workaround for the bug in `flow_thanks_tests.py`, and document the bug. - Sorting by 'newest' and slicing the generator. [x] Improve the assertion in unit test scripts to make it more precise and meaningful. [x] Use ordinary slice instead of islice() - Ordinary slice cannot be used for iterators and generators in python. [x] Shift `flow_thanks.py` to maintenance folder. [x] Adhere to coding linting rules. [x] Remove `u""` since we're using unicode literals. [x] `thank_flowpost` should take APISite as a parameter. [x] If `user.thanks_enabled=False`, then what? - Not implementing thanks_enabled in this task now. - TODO later. [x] Improve implementation of getting Site object. [x] If user doesn't specify arguments, then what? - Error raised. [x] Remove the list post_ids[] and rename it appropriately. [ ] Use self.assertRaises to check for exceptions thrown for bad data. Account for as many as possible. [ ] Add tests for new site.py method.

{icon calendar} | Friday, 24th June 2016 - 15:30 UTC {icon user} | jayvdb, legoktm, darthbhyrava **Skype** **Description**: Final Weekly Meeting before the Mid-Term Evaluation *** === Agenda: - Review patch for T135409 : [[ https://gerrit.wikimedia.org/r/#/c/294901/ | 294901 ]]. - Review patch for T135411: [[ https://gerrit.wikimedia.org/r/#/c/295132/ | 295132 ]]. - Determine necessary changes so that the patches pass with `+2` from `jenkins`. - Other requirements for passing Mid-Term Evaluations: [x] Submitting the Evaluation Form [x] Updating Weekly Reports - T133667 [ ] Changes pushed to local GitHub repository. Changes made since last meet : ===== Subtask I [x] Use the Revision class instead of a recursive function to get revision details in `thanks.py`. [x] Remove the hack and let `User.thanks_enabled` do the job in `thanks_tests.py`. [x] Improve the assertion in unit test scripts to make it more precise and meaningful. [x] Shift to variable `revid` consistently throughout. [x] Add source as a user customisable parameter to def `get_revision()` in site.py [x] Shift the above method in site.py next to the other revision methods. [x] Shift `thanks.py` to maintenance folder. [x] Adhere to coding linting rules. [x] Remove `u""` since we're using unicode literals. [x] `thank_rev` should take APISite as a parameter. [x] If `user.thanks_enabled=False`, then what? [x] If user doesn't specify arguments, then what? [x] Use self.assertRaises to check for exceptions thrown for bad data. Account for as many as possible. [x] Change name of unit test class to a non-abbreviated one. [x] Improve implementation of getting Site object. [ ] Add tests for new site.py method. //What class, what to assert?// [ ] Add `write=True` to thanks_tests as per tests/README // Tests fail, ask me to add PYWIKIBOT2_TEST_WRITE=1// [ ] Make direct calls to page.py and site.py for unit test. //On hold - what are we testing, then?// ===== Subtask II [ x] Look into and document all errors caused by `sort_by='updated'` param in `flow_thanks_tests.py`. [ ] Get a suitable workaround for the bug in `flow_thanks_tests.py` - jayvdb got to it before me: please look at T138323, T138215, T138307, and document the bugT138306. [x] Get a suitable workaround for the bug in `flow_thanks_tests.py`, ] Improve the assertion in unit test scripts to make it more precise and meaningfuland document the bug. [ ] Use ordinary slice instead of islice() - Sorting by 'newest' and slicing the generator. [ ] Add tests for new site.py methodx] Improve the assertion in unit test scripts to make it more precise and meaningful. [ ] Shift `flow_thanks.py` to maintenance folder.x] Use ordinary slice instead of islice() [ ] Adhere to coding linting rules - Ordinary slice cannot be used for iterators and generators in python. [ ] Remove `u""` since we're using unicode literalsx] Shift `flow_thanks.py` to maintenance folder. [ ] `thank_flowpost` should take APISite as a parameterx] Adhere to coding linting rules. [ ] If `user.thanks_enabled=False`, then what?x] Remove `u""` since we're using unicode literals. [ ] Improve implementation of getting Site objectx] `thank_flowpost` should take APISite as a parameter. [ x] If `user doesn't specify arguments.thanks_enabled=False`, then what? [ ] Use self.assertRaises to check for exceptions thrown for bad data. - Not implementing thanks_enabled in this task now. Account for as many as possible- TODO later. [ ] Remx] Improve the list post_ids[] and rename it appropriatelyimplementation of getting Site object. [x] If user doesn't specify arguments, then what? ] Add tests for new site.py method- Error raised. [x] Remove the list post_ids[] and rename it appropriately. [ ] Add testsUse self.assertRaises to check for exceptions thrown for border casesad data. Account for as many as possible. [ ] Add tests for new site.py method.