Change Details

{T229363} adds a parsoidPHPURL to the client config. Now, we need a mechanism for roundtrip-test.js to use the current default (JS) url or pick the PHP url so we run rt testing with Parsoid/JS or Parsoid/PHP. One way to do this is for the script to check for the presence of a file (or its contents) on disk that we manually toggle to pick what version we want to run. This lets us switch versions on our own without code commits or puppet changes.

{T229363} adds a parsoidPHPURL to the client config. We need two things: 1. Now, we need a mechanism for roundtrip-test.js to use the current default (JS) url or pick the PHP url so we run rt testing with Parsoid/JS or Parsoid/PHP. One way to do this is for the script to check for the presence of a file (or its contents) on disk that we manually toggle to pick what version we want to run. This lets us switch versions on our own without code commits or puppet changes. 2. The Parsoid/JS curl command is `curl http://localhost:8142/<domain>/v3/page/html/<title>/<revid>` and Parsoid/PHP curl command is `curl -x scandium.eqiad.wmnet:80 http://<domain>/w/rest.php/<domain>/v3/page/html/<titie>/<revid>`. So, we need to ensure we compute the parsoid/php url appropriately. It will not be based on parsoidPHPURL as it is set up in puppet. We could make it a format-string instead. Plus, we need to direct the request to the proxy, not localhost. So, we may need to enhance the client settings in puppet to include that as well.

{T229363} adds a parsoidPHPURL to the client config. Now, we need a mechanism for roundtrip-test.js to use the current default (JS) url or pick the PHP url so we run rt testing with Parsoid/JS or Parsoid/PHP.We need two things: 1. Now, we need a mechanism for roundtrip-test.js to use the current default (JS) url or pick the PHP url so we run rt testing with Parsoid/JS or Parsoid/PHP. One way to do this is for the script to check for the presence of a file (or its contents) on disk that we manually toggle to pick what version we want to run. This lets us switch versions on our own without code commits or puppet changes. 2. The Parsoid/JS curl command is `curl http://localhost:8142/<domain>/v3/page/html/<title>/<revid>` and Parsoid/PHP curl command is `curl -x scandium.eqiad.wmnet:80 http://<domain>/w/rest.php/<domain>/v3/page/html/<titie>/<revid>`. So, we need to ensure we compute the parsoid/php url appropriately. It will not be based on parsoidPHPURL as it is set up in puppet. We could make it a format-string instead. Plus, we need to direct the request to the proxy, not localhost. So, we may need to enhance the client settings in puppet to include that as well.