Change Details

Umherirrender added a patch, gerrit 154452, which adds a site js/css user right, similar to the right to edit user js/css (bug 8834). I want to track this with a bug, so we can document the decision to implement this, if we decide to. I've thought about implementing this for a while, and I'm happy to see it done. I think this is an improvement in MediaWiki supporting least privilege / separation of duty. In the last few weeks, there has been a lot of discussion about supporting a more formal code review process for site js/css. In my first look, I don't think Umherirrender's patch conflicts with this goal, but if it does, that would potentially be a reason to not merge it. Other thoughts? -------------------------- **Version**: 1.24rc **Severity**: normal

Umherirrender added a patch, [[ https://gerrit.wikimedia.org/r/#/c/154452/ | gerrit 154452 ]], which adds a site js/css user right, similar to the right to edit user js/css (T10834). I want to track this with a bug, so we can document the decision to implement this, if we decide to. I've thought about implementing this for a while, and I'm happy to see it done. I think this is an improvement in MediaWiki supporting least privilege / separation of duty. In the last few weeks, there has been a lot of discussion about supporting a more formal code review process for site js/css. In my first look, I don't think Umherirrender's patch conflicts with this goal, but if it does, that would potentially be a reason to not merge it. Other thoughts? -------------------------- **Version**: 1.24rc **Severity**: normal

Umherirrender added a patch, [[ https://gerrit.wikimedia.org/r/#/c/154452/ | gerrit 154452 ]], which adds a site js/css user right, similar to the right to edit user js/css (bug 8834T10834). I want to track this with a bug, so we can document the decision to implement this, if we decide to. I've thought about implementing this for a while, and I'm happy to see it done. I think this is an improvement in MediaWiki supporting least privilege / separation of duty. In the last few weeks, there has been a lot of discussion about supporting a more formal code review process for site js/css. In my first look, I don't think Umherirrender's patch conflicts with this goal, but if it does, that would potentially be a reason to not merge it. Other thoughts? -------------------------- **Version**: 1.24rc **Severity**: normal