Change Details

{T187916} After we finished work on modal, we have 1 minor follow up tweak around this work The top alignment for text and the icon {F15976205} Note: modal name should be "Page issues" (as is currently) = Developer notes Can be seen here: https://en.m.wikipedia.org/wiki/Offset_printing While tempting to add a top: -2px we should investigate the route cause - the HTML elements themselves are aligned but the paragraph o text gets top padding from somewhere. We should not incur tech debt as part of this change. We may need to look at the implementation of mw-ui-icon

{T187916} After we finished work on modal, we have 1 minor follow up tweak around this work The top alignment for text and the icon {F15976205} Note: modal name should be "Page issues" (as is currently) = Developer notes Can be seen here: https://en.m.wikipedia.org/wiki/Offset_printing While tempting to add a top: -2px we should investigate the route cause - the HTML elements themselves are aligned but the paragraph o text gets top padding from somewhere. We should not incur tech debt as part of this change. We may need to look at the implementation of mw-ui-icon = Testing Criteria 1. visit http://reading-web-staging.wmflabs.org/wiki/Infrastructure?useformat=mobile#/issues 2. ensure that the top of the icon (orange circle) is aligned with the top of the text ("This article...") 3. check on multiple browsers (mobile & desktop) 4. repeat steps 1–3 with http://reading-web-staging.wmflabs.org/wiki/Rowing_(sport)?useformat=mobile#/issues

{T187916} After we finished work on modal, we have 1 minor follow up tweak around this work The top alignment for text and the icon {F15976205} Note: modal name should be "Page issues" (as is currently) = Developer notes Can be seen here: https://en.m.wikipedia.org/wiki/Offset_printing While tempting to add a top: -2px we should investigate the route cause - the HTML elements themselves are aligned but the paragraph o text gets top padding from somewhere. We should not incur tech debt as part of this change. We may need to look at the implementation of mw-ui-icon = Testing Criteria 1. visit http://reading-web-staging.wmflabs.org/wiki/Infrastructure?useformat=mobile#/issues 2. ensure that the top of the icon (orange circle) is aligned with the top of the text ("This article...") 3. check on multiple browsers (mobile & desktop) 4. repeat steps 1–3 with http://reading-web-staging.wmflabs.org/wiki/Rowing_(sport)?useformat=mobile#/issues