Change Details

As a follow-up to T174237 we should also care about minor misalignments of ULS settings dialog. [x] Font-size of dialog (widgets) in Vector. We should aim for 14px base font-size equivalent, similar to OOUI in MW core – https://gerrit.wikimedia.org/r/387970 [] Headlines too light gray. We should aim for equivalence with Notifications/Alerts dialog [x] Box shadow too strong, let's go for standard `box-shadow-dialog` instead [x] Close icon not following WikimediaUI icon set. See also T50067 [x] Confirmation buttons are too far left, using wider grid column should solve this – https://gerrit.wikimedia.org/r/387974 [x] Putting Language settings headline a bit higher and closing the gap between close button row and contents | Before | With proposed patches applied | | -- | -- | {F10563545 width=100%} | {F10563543 width=50%}

As a follow-up to T174237 we should also care about minor misalignments of ULS settings dialog. [x] Font-size of dialog (widgets) in Vector. We should aim for 14px base font-size equivalent, similar to OOUI in MW core – https://gerrit.wikimedia.org/r/387970 [x] Headlines too light gray. We should aim for equivalence with Notifications/Alerts dialog [x] Box shadow too strong, let's go for standard `box-shadow-dialog` instead [x] Close icon not following WikimediaUI icon set. See also T50067 [x] Confirmation buttons are too far left, using wider grid column should solve this – https://gerrit.wikimedia.org/r/387974 [x] Putting Language settings headline a bit higher and closing the gap between close button row and contents [] Vertical gaps on EN:WP due to style rules lurking into dialog | Before | With proposed patches applied | | -- | -- | {F10563545 width=100%} | {F10563543 width=50%}

As a follow-up to T174237 we should also care about minor misalignments of ULS settings dialog. [x] Font-size of dialog (widgets) in Vector. We should aim for 14px base font-size equivalent, similar to OOUI in MW core – https://gerrit.wikimedia.org/r/387970 [x] Headlines too light gray. We should aim for equivalence with Notifications/Alerts dialog [x] Box shadow too strong, let's go for standard `box-shadow-dialog` instead [x] Close icon not following WikimediaUI icon set. See also T50067 [x] Confirmation buttons are too far left, using wider grid column should solve this – https://gerrit.wikimedia.org/r/387974 [x] Putting Language settings headline a bit higher and closing the gap between close button row and contents [] Vertical gaps on EN:WP due to style rules lurking into dialog | Before | With proposed patches applied | | -- | -- | {F10563545 width=100%} | {F10563543 width=50%}