This task lists all bugs found when reviewing Lingua Libre v3
Deployment:
- [x] Toolforge > deployment thanks to Pushkar, Aditya and Yug.
### UI, i18n, others
Low hanging fruits to fix -> Aditya :
- [x] #1 T399383 Step 0 : Login > replace intermediate message page spinner.
- [x] #2 T399384 Step 1 > Licenses selector appeared empty and shrunked.
- [x] #3 T399387 Step 1 > Input elements for location need an hint.
- [x] #4 [cancelled] Step 1 >Languages rows need limit to empty creation.
- [x] #5 & #14 : use **working language** Qid to provide ISOs. Helpers: [[ https://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q150&props=claims&format=json | API request > Q150 > P218, P219, P220]]) ; [[ https://gitlab.wikimedia.org/repos/wikimedia-france/lingua-libre/lingua-libre/-/blob/main/front-end/src/stores/labels.js | labels.js]]
- [x] #5 T399400 Step 4 > List generator [LocalListDialog.vue](https://gitlab.wikimedia.org/repos/wikimedia-france/lingua-libre/lingua-libre/-/blob/main/front-end/src/components/Generators/LocalListDialog.vue) input field should be prefilled with `List:{iso3}/.
- [x] #14a T399401 Step 4: Generators/[NearbyDialog.vue](https://gitlab.wikimedia.org/repos/wikimedia-france/lingua-libre/lingua-libre/-/blob/main/front-end/src/components/Generators/NearbyDialog.vue?ref_type=heads#L139-145) hard coded `en` to replace with `iso1`.
- [x] #14b T399402 Step 4: Generators/NearbyDialog.vue crash when `item.labels.en.value` is empty string, need to filter out empty values. ([827a33](https://gitlab.wikimedia.org/repos/wikimedia-france/lingua-libre/lingua-libre/-/commit/827a33bc10ffc8cdeb815b983370f2a5a0259ffb))
- [x] #6 T399397 Step 4 > Lexeme generator shows Qid, should show human readable language name
- [x] T397834 Ensure select element's item display their labels in the user-chosen UI language
- [x] #17 T399391 Step 4 > "Skip to the next word" button shows blank screen on last word
- [x] #7 T399392 Step 5 > CSS on ticked box is misaligned.
- [x] #8 T399393 Step 6 > Upload to Commons wikitext is incorrect
- [x] #16 T399395 Spread i18n string calls across the app
- [x] #18 T399396 Step 4: GeneratorCategories must support more wikimedia wikis
- [x] Selector with exhaustive list of wikimedia projects
- [x] Item fetched are `Category:Dog`, corrected to `Dog` or `dog`.
- [ ] #19 T399390 Step 1: Set speaker's license as required
Q: (At Step 2,) when a language is selected as working language to document. We have its Qid ([[ https://gitlab.wikimedia.org/repos/wikimedia-france/lingua-libre/lingua-libre/-/blob/main/front-end/src/components/Generators/WikidataLexemeDialog.vue#L41 | ex ]]]]), what other properties/values do we have access to ? Do we have iso2 and iso3 ?
{F62821910}
{F62766838}
{F62766801}
{F62766802}
### Postponed
- [ ] #9 [low] Step 1 > Place search input field should not show non-places items, possibility to refine ([current query](https://www.wikidata.org/w/api.php?action=wbsearchentities&format=json&origin=*&search=Orx&language=en&uselang=en&limit=7)) ? (not critical, could be hard! = pass)
{F62766800}
{F62766799}
### Deeper issues -> Pushkar
- [x] #10 Step 6, after click on "Publish!" :
- [x] #10a T399404 Step 6 > Batch uploads stay pending without uploads. Solved: [[ https://gitlab.wikimedia.org/repos/wikimedia-france/lingua-libre/lingua-libre/-/merge_requests/56/diffs | PR56 ]]
- [x] #10b T399408 Step 6 > SDC not sent (see [[ https://commons.wikimedia.org/wiki/File:LL-Q150%E2%80%94Yug%E2%80%94inédit.wav | ex ]])
- [x] #10c T399405 Step 6 > Publish! sends ALL recordings, should send **selected**.
- [x] #10d T399406 Step 6 > Uploader's counter is incorrect, counts the number of clicks-select actions of check-boxes, should be number of currently selected.
- [ ] #10e T399407 SDC P9533 language is incorrect, should be Qid of language being recorded, not english.
- [x] #11 Videos miniatures appear as audio [here](https://commons.wikimedia.org/w/index.php?title=Special:ListFiles/Pushkar7077). See [T312554#8782255](https://phabricator.wikimedia.org/T312554#8782255) and [ee86f4ea](https://github.com/lingua-libre/RecordWizard/commit/ee86f4ea03d8978891fc71c2d55e0de28ed322da). It uses FFMPEG server side.
- [ ] #12 [Yug] T397834 : Genders
- [ ] #13 [Yug] Step 4 (List) > Button "Exclude words you have already recorded" and "Remove words already recorded" needs new API request and code. Inspiration : [n⁰1](https://jsfiddle.net/hugolpz/3bd4L02e/5/)
Step 6's counter is off, counting wrong thing :
{F63175934}
Step 5 Recording order, Step 6 get inverted :
{F63175933}
{F63175451}
{F63034167}
{F63034128}
### Other
- [x] #15 Clean up toolforge : `~/www/js/` <repository> seems useless and could be remove. Indeed :
- `~/www/python/src/` is the MariaDB + Django instance
- `~/www/python/src/front-end/dist/` is the front-end, deployed by [gitlab-ci.yml](https://gitlab.wikimedia.org/repos/wikimedia-france/lingua-libre/lingua-libre/-/blob/main/.gitlab-ci.yml?ref_type=heads#L109-121)
- test : move `/js/`'s content.