Change Details

The Popups build check is permitting the source inputs and build outputs to become out of sync. This is very dangerous as build products are not code reviewed and arbitrary code could be shipped to prod unknowingly. A failed attempt to fix the issue is [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/454566/ | here ]].

The Popups build check is permitting the source inputs and build outputs to become out of sync. This is very dangerous as build products are not code reviewed and arbitrary code could be shipped to prod unknowingly. A failed attempt to fix the issue is [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/454566/ | here ]]. = Observed behavior The patch [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/454435 | Use getPageviewToken api ]] does not update the built assets. `npm run check-built-assets` when run does not throw an error code meaning Jenkins does not catch this mistake and allows the possibility of not deploying the changes that have been made. = Acceptance criteria [] Any change which updates the code in resources/dist/ should fail Jenkins checks if that code has not been committed.

The Popups build check is permitting the source inputs and build outputs to become out of sync. This is very dangerous as build products are not code reviewed and arbitrary code could be shipped to prod unknowingly. A failed attempt to fix the issue is [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/454566/ | here ]]. = Observed behavior The patch [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/454435 | Use getPageviewToken api ]] does not update the built assets. `npm run check-built-assets` when run does not throw an error code meaning Jenkins does not catch this mistake and allows the possibility of not deploying the changes that have been made. = Acceptance criteria [] Any change which updates the code in resources/dist/ should fail Jenkins checks if that code has not been committed.