Change Details

#### Description This should be one of the final tasks completed for the new Impact Module. It is basically a reminder for us to meet our Accessibility goals and check a few other edge bases. #### Acceptance Criteria **Accessibility Goals:** [] All Positive Reinforcement features pass Chrome Lighthouse and QA Accessibility scan [] All features we work on for Positive Reinforcement are navigable by keyboard [] Impact Module graphs have alt text that conveys the basic meaning of the chart **Edge cases:** [] If a thumbnail doesn't load, (certain SVGs are not being rendered properly as thumbnails) then we instead show the standard placeholder thumbnail image. Example: {F35320879} ------ #### Completion checklist **Functionality** [] The patches have been code reviewed and merged [] The task passes its acceptance criteria **Engineering** [] There are existing and passing unit/integration tests [] Tests for every involved patch should pass [] Coverage for every involved project should have improved or stayed the same **Design & QA** [] If the task is UX/Design related: it must be reviewed and approved by the UX/Design team [] Must be reviewed and approved by Quality Assurance. **Documentation** [] Related and updated documentation done where necessary - Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc) - Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments | Extension:GrowthExperiments ]] or [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments/Technical_documentation | Extension:GrowthExperiments/Technical documentation ]] pages.

#### Description This should be one of the final tasks completed for the new Impact Module. It is basically a reminder for us to meet our Accessibility goals and check a few other edge bases. #### Acceptance Criteria **Accessibility Goals:** [] All Positive Reinforcement features pass Chrome Lighthouse and QA Accessibility scan [x] All features we work on for Positive Reinforcement are navigable by keyboard [] Impact Module graphs have alt text that conveys the basic meaning of the chart **Edge cases:** [x] If a thumbnail doesn't load, (certain SVGs are not being rendered properly as thumbnails) then we instead show the standard placeholder thumbnail image. Example: {F35320879} ------ #### Completion checklist **Functionality** [] The patches have been code reviewed and merged [] The task passes its acceptance criteria **Engineering** [] There are existing and passing unit/integration tests [] Tests for every involved patch should pass [] Coverage for every involved project should have improved or stayed the same **Design & QA** [] If the task is UX/Design related: it must be reviewed and approved by the UX/Design team [] Must be reviewed and approved by Quality Assurance. **Documentation** [] Related and updated documentation done where necessary - Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc) - Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments | Extension:GrowthExperiments ]] or [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments/Technical_documentation | Extension:GrowthExperiments/Technical documentation ]] pages.

#### Description This should be one of the final tasks completed for the new Impact Module. It is basically a reminder for us to meet our Accessibility goals and check a few other edge bases. #### Acceptance Criteria **Accessibility Goals:** [] All Positive Reinforcement features pass Chrome Lighthouse and QA Accessibility scan [x] All features we work on for Positive Reinforcement are navigable by keyboard [] Impact Module graphs have alt text that conveys the basic meaning of the chart **Edge cases:** [x] If a thumbnail doesn't load, (certain SVGs are not being rendered properly as thumbnails) then we instead show the standard placeholder thumbnail image. Example: {F35320879} ------ #### Completion checklist **Functionality** [] The patches have been code reviewed and merged [] The task passes its acceptance criteria **Engineering** [] There are existing and passing unit/integration tests [] Tests for every involved patch should pass [] Coverage for every involved project should have improved or stayed the same **Design & QA** [] If the task is UX/Design related: it must be reviewed and approved by the UX/Design team [] Must be reviewed and approved by Quality Assurance. **Documentation** [] Related and updated documentation done where necessary - Internal technical changes: internal repository documentation must be updated (README.md, JSDoc, PHPDoc) - Infrastructure technical changes: technical changes that reflect on environment, infrastructure, endpoints or any other area of interest for technical contributors should be reflected on [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments | Extension:GrowthExperiments ]] or [[ https://www.mediawiki.org/wiki/Extension:GrowthExperiments/Technical_documentation | Extension:GrowthExperiments/Technical documentation ]] pages.