Change Details

Since Revision::getRevisionText() uses the old_text field which is obtained by joining rev_text_id or ar_text_id against text.old_id, it can no longer be used with queries based on getQueryInfo() or getSelectFields(), once rev_text_id and ar_text_id go away. Code that interacts with the text table directly should use SqlBobStore::expandBlob instead. Code that operates on the revision table should use the appropriate methods in RevisionStore and RevisionRecord to access content. DOD: This task should be considered done when any code calling Revision::getRevisionText() has been, in core and all extensions deployed by Wikimedia, as well as extensions bundled with MediaWiki releases. Other extensions and external tools may be left to be updated later. NOTE: fixes for this will probably coincide with fixes for {T198342} and {T198341}.

Since Revision::getRevisionText() uses the old_text field which is obtained by joining rev_text_id or ar_text_id against text.old_id, it can no longer be used with queries based on getQueryInfo() or getSelectFields(), once rev_text_id and ar_text_id go away. Code that interacts with the text table directly should use SqlBobStore::expandBlob instead. Code that operates on the revision table should use the appropriate methods in RevisionStore and RevisionRecord to access content. See [[https://codesearch.wmflabs.org/extensions/?q=Revision%3A%3AgetRevisionText&i=nope&files=&repos=|Uses of Revision::getRevisionText() in extensions]]. DOD: This task should be considered done when any code calling Revision::getRevisionText() has been, in core and all extensions deployed by Wikimedia, as well as extensions bundled with MediaWiki releases. Other extensions and external tools may be left to be updated later. NOTE: fixes for this will probably coincide with fixes for {T198342} and {T198341}.

Since Revision::getRevisionText() uses the old_text field which is obtained by joining rev_text_id or ar_text_id against text.old_id, it can no longer be used with queries based on getQueryInfo() or getSelectFields(), once rev_text_id and ar_text_id go away. Code that interacts with the text table directly should use SqlBobStore::expandBlob instead. Code that operates on the revision table should use the appropriate methods in RevisionStore and RevisionRecord to access content. See [[https://codesearch.wmflabs.org/extensions/?q=Revision%3A%3AgetRevisionText&i=nope&files=&repos=|Uses of Revision::getRevisionText() in extensions]]. DOD: This task should be considered done when any code calling Revision::getRevisionText() has been, in core and all extensions deployed by Wikimedia, as well as extensions bundled with MediaWiki releases. Other extensions and external tools may be left to be updated later. NOTE: fixes for this will probably coincide with fixes for {T198342} and {T198341}.