//([[ http://fab.wmflabs.org/T274 | The code review process in Differential/Audit needs to be adapted to our needs ]] has been moved to an own taskIt is not possible to "-1" or to "+2" a diff in Phabricator exactly like you would do in Gerrit. Then again, sorry for the noise)//we seem to have all the pieces in place.
We need:
Phabricator seems to allow to “Accept” a revision (like our „Code-Review+2”), but it could not find ways to vote finer gradings, like our “Code-Review+1”* Possibility for All Users to add positive/negative comments and symbols (+1 and -1 are in fact symbols, or “Code-Review-1”.not votes, ([[ https://gerrit.wikimedia.org/r/#/c/115607/ | example ]])since the decision over a review is not based on counting votes).
Sure* Possibility for the maintainers of a repository and only for them to reject or approve a diff, we can just comment “+1” / “-1” on the Differential revision.the later action implying the merge of the diff (triggering whatever CI process we have in place).
* Possibility for anybody to abandon a diff, But that's no solutionand recover an abandoned diff.
To be clear about policies: users should not be able to merge or reject a diff in a repo, as it textual votes are hard to identify even if there are only a few comments.unless they are the maintainers.
Are there other scenarios related with evaluation of diffs that we should consider?