Change Details

This change in core MediaWiki, in version 1.31, broke full-text search in Special:Drilldown in Cargo: https://phabricator.wikimedia.org/rMW0824579606fe2f5920d2aeb5ab7d1a4bc4838007 I got full-text search working again for MW 1.31+ about a month ago, with this change: https://phabricator.wikimedia.org/rECRGbbed4f2d590fccb560f16f31b3345e2fa5b370bb Unfortunately, it broke full-text search for MediaWiki 1.30 and lower, which I didn't discover until recently. I don't know of a way to have one "CargoSearchMySQL" class that will work with all versions of MediaWiki. Therefore, I think the easiest fix for this is to have two different files, both defining a "CargoSearchMySQL" class, with one file holding the old contents of CargoSearchMySQL.php and one holding the new contents. (Perhaps the files should be called CargoSearchMySQL.php and CargoSearchMySQL-old.php.) Instead of being loaded in extension.json and Cargo.php, they should be loaded in registerExtension() within Cargo.hooks.php, so that there can be an "if" statement call to load the right one, depending on the MW version.

This change in core MediaWiki, in version 1.31, broke full-text search in Special:Drilldown in Cargo: https://phabricator.wikimedia.org/rMW0824579606fe2f5920d2aeb5ab7d1a4bc4838007 I got full-text search working again for the latest MediaWiki version about a month ago, with this change: https://phabricator.wikimedia.org/rECRGbbed4f2d590fccb560f16f31b3345e2fa5b370bb Unfortunately, it broke full-text search for MediaWiki 1.31 and lower, which I didn't discover until recently. ~~I don't know of a way to have one "CargoSearchMySQL" class that will work with all versions of MediaWiki. Therefore, I think the easiest fix for this is to have two different files, both defining a "CargoSearchMySQL" class, with one file holding the old contents of CargoSearchMySQL.php and one holding the new contents. (Perhaps the files should be called CargoSearchMySQL.php and CargoSearchMySQL-old.php.) Instead of being loaded in extension.json and Cargo.php, they should be loaded in registerExtension() within Cargo.hooks.php, so that there can be an "if" statement call to load the right one, depending on the MW version.~~ (please ignore this) That's for two reasons: "public" methods being overriden as "private" (which PHP doesn't allow), and because of another change in core MediaWiki, this one in version 1.31: https://phabricator.wikimedia.org/rMW90d4f56fe46140f9e97e2fa72698f98b57447fe5 CargoSearchMySQL should ideally support both the old $wgContLang and the new MediaWikiServices::getInstance()->getContentLanguage(), depending on what is available in the MediaWiki version being used.

This change in core MediaWiki, in version 1.31, broke full-text search in Special:Drilldown in Cargo: https://phabricator.wikimedia.org/rMW0824579606fe2f5920d2aeb5ab7d1a4bc4838007 I got full-text search working again for MW 1.31+the latest MediaWiki version about a month ago, with this change: https://phabricator.wikimedia.org/rECRGbbed4f2d590fccb560f16f31b3345e2fa5b370bb Unfortunately, it broke full-text search for MediaWiki 1.3031 and lower, which I didn't discover until recently. ~~I don't know of a way to have one "CargoSearchMySQL" class that will work with all versions of MediaWiki. Therefore, I think the easiest fix for this is to have two different files, both defining a "CargoSearchMySQL" class, with one file holding the old contents of CargoSearchMySQL.php and one holding the new contents. (Perhaps the files should be called CargoSearchMySQL.php and CargoSearchMySQL-old.php.) Instead of being loaded in extension.json and Cargo.php, they should be loaded in registerExtension() within Cargo.hooks.php, so that there can be an "if" statement call to load the right one, depending on the MW version.~~ (please ignore this) That's for two reasons: "public" methods being overriden as "private" (which PHP doesn't allow), and because of another change in core MediaWiki, this one in version 1.31: https://phabricator.wikimedia.org/rMW90d4f56fe46140f9e97e2fa72698f98b57447fe5 CargoSearchMySQL should ideally support both the old $wgContLang and the new MediaWikiServices::getInstance()->getContentLanguage(), depending on what is available in the MWediaWiki versionn being used.