As discussed in the Operations offsite we'd like to add some CI checks for shell scripts, probably non voting at the start given the current status of the repo.
The first two tools that we could add are:
* [[ https://github.com/koalaman/shellcheck | ShellCheck ]]
* checkbashisms (from the [[ https://packages.debian.org/jessie/devscripts | devscripts ]] Debian package). See T95064 for the current status of the `operations/puppet` repo as an example.
And of course investigate to see if there are more worth adding.
We should also agree on a policy for 3rd party scripts that were imported as is in our repositories:
# Keeping as is and excluding them from the checks + optional reporting it upstream and wait for a new version
# Modifying them with a clear Changelog entry + optional reporting it upstread with a pull request