For the MediaWiki 1.23.4 release, a patch file was provided that was based on all files in Git, instead of just the files we provide in a tarball. As a result, the audience the patch is intended for (using tarball instead of Git), could not apply it cleanly without warnings.
>>! **Original task description** by @robkam
>
> Intention:
> Trying to patch mediawiki 1.23.3 to mediawiki-1.23.4.patch.
>
> Steps to Reproduce:
> patch -p 1 --dry-run < mediawiki-1.23.4.patch
>
>
> ```lines=10,name=Actual Results
> patching file includes/config/GlobalVarConfig.php
> patching file includes/db/DatabaseMysqli.php
> patching file includes/DefaultSettings.php
> patching file includes/libs/XmlTypeCheck.php
> patching file includes/Sanitizer.php
> patching file includes/upload/UploadBase.php
> patching file RELEASE-NOTES-1.23
> can't find file to patch at input line 387
> Perhaps you used the wrong -p or --strip option?
> ```
> The text leading up to this was:
> ```
> |diff -Nruw -x messages -x '*.png' -x '*.jpg' -x '*.xcf' -x '*.gif' -x '*.svg' - x '*.tiff' -x '*.zip' -x '*.xmp' -x '.git*' mediawiki-1.23.3/tests/phpunit/inclu des/upload/UploadBaseTest.php mediawiki-1.23.4/tests/phpunit/includes/upload/Upl oadBaseTest.php
> |--- mediawiki-1.23.3/tests/phpunit/includes/upload/UploadBaseTest.php 2014-09- 24 19:58:10.961599096 +0000
> |+++ mediawiki-1.23.4/tests/phpunit/includes/upload/UploadBaseTest.php 2014-09- 24 19:55:15.538575503 +0000
> ```
>
> Reproducible: Always
>
> So I ran it anyway and wiki now is version 1.23.4 - it seems to be only the non-existent UploadBaseTest.php that has not been patched. Is this right/there nothing to worry about?
>