== Background
We show users opted into the ReadingLists beta feature (which now includes all new accounts) an onboarding popover the first time they view an article.
This popover conflicts with the Contributor Growth team's revise tone onboarding dialog, which is displayed when a user:
- Is opted into the newcomer homepage
- Visits Special:Homepage
- Opens the pool of suggested edits
- Picks a "revise tone" edit
- Is taken to the article's edit page and shown an onboarding dialog
(from @AAlhazwani-WMF)
| {F81213026 size=thumb} | {F81213031} |
=== User story
As a new editor, I want to focus on editor onboarding features.
---
== Requirements
=== Technical requirements
Ideally, we would bail out of showing the ReadingLists onboarding popover when the URL indicates edit mode but not mark the onboarding popover as seen, to give the user another opportunity to see it when they're actually reading an article.
=== Acceptance criteria
For a user who has not yet seen the ReadingLists onboarding popover...
- [x] Don't show the popover when the user is editing an article
- [] [nice to have] Show the popover when the user subsequently views an article
=== BDD
====**Scenario 1:**
A user doesn't see the ReadingList onboarding popover in any of Suggested Edit tasks
**Given** the user with enabled Saved pages option goes to any of SE tasks from Homepage
**When **the user is on an article page with Suggested Edits (structured or unstructured)
**Then** the user doesn't see the ReadingList popover
=====**Scenario 2:**
A user will see the ReadingList onboarding popover when any article from
**Given** the user with enabled Saved pages option goes any article
**When **the user is on an article page
**Then** the user sees the ReadingList popover onboarding
=== Test Steps
Test the scenarios in BDD for
-- a new account
-- for an existing account with disabled Homepage
-- for an existing account who resets to default settings
=== Communication criteria
//Add if this needs an announcement or discussion.//
=== Rollback plan
//Describe the rollback plan in production for this task if something goes wrong.//
//This task was created by Version 1.0.0 of the Reader Experience team task template using [[ https://phabulous.toolforge.org/ | phabulous ]].//
=== BDD
```
Feature: Suppress ReadingLists onboarding popover in edit mode
Background:
Given I am a logged-in user opted into the ReadingLists beta feature
Scenario: Editing an article does not show the popover
When I open an article in edit mode (action=edit)
Then the ReadingLists onboarding popover is not shown
And the onboarding module does not initialize
Scenario: Reading an article still shows the popover (fresh user)
Given I have not yet seen the popover
When I view the article in read mode
Then the ReadingLists onboarding popover is shown
```
=== Test Plan
Test Case 1: Edit mode suppresses the popover
Open an article in edit mode (?action=edit), logged in + ReadingLists beta.
AC1: The ReadingLists onboarding popover does NOT appear; the onboarding module does not load/initialize.
Test Case 2: Read mode shows the popover (fresh account) [MANUAL — not-yet-onboarded account]
AC2: For a user who hasn't seen it, viewing in read mode shows the popover; it is not marked seen in edit mode.
| AC | Status | Details for test run [ T426194#12060478
=== Test Results ] |
| --- | --- | --- |
| 1 | ✅ | edit mode (Berlin ?action=edit): ext.readingLists.onboarding state "registered" (not loaded), no popover — see T426194_loggedin_AC1_1.png |
| 2 | ⬜ | manual — needs a not-yet-onboarded account (test account already onboarded; seen-state is server-side, onboarding doesn't load in read mode either) |