Change Details

Inspired by T169457... There are at least two cases where rollback and null edits (e.g. protection events) do not interact well. Suppose "Bot" is a page-protection bot (it could also be a Sysop doing that manually and missing the vandalism). Any log-type null-edit generating event will do. Case I ---- **Edit 3 - Admin; manual revert to version #0** Edit 2 - Bot; null edit (=version #1) Edit 1 - Vandal; vandalism Edit 0 - Editor; OK version Rollback was not an option for Admin here since rollback of #2 would try to revert Bot and go to #1. Those have the same text, so it would error out. Ideally edit #3 could be "Reverted edits by Vandal to last version by Editor)" via [rollback]. Case II ---- **Edit 4 - Admin; manual revert to version #0** Edit 3 - Vandal; vandalism Edit 2 - Bot; null edit (=version #1) Edit 1 - Vandal; vandalism Edit 0 - Editor; OK version Rollback was not an option for Admin since they noticed the vandalism from #1 too. Ideally edit #4 could be "Reverted edits by Vandal to last version by Editor)" via [rollback]. This won't handle the case were the edits were from two different vandals, but it could at least detect that they are the same. Since this is relatively rare DB traffic wise, it could be done in loops of the current code, checking rev_sha1 and moving further down (both for "bad user" selection and "last different version by someone else".

Inspired by T169457... There are at least two cases where rollback and null edits (e.g. protection events) do not interact well. Suppose "Bot" is a page-protection bot (it could also be a Sysop doing that manually and missing the vandalism). Any log-type null-edit generating event will do. Case I ---- **Edit 3 - Admin; manual revert to version #0** Edit 2 - Bot; null edit (=version #1) Edit 1 - Vandal; vandalism Edit 0 - Editor; OK version Rollback was not an option for Admin here since rollback of #2 would try to revert Bot and go to #1. Those have the same text, so it would error out. Ideally edit #3 could be "Reverted edits by Vandal to last version by Editor)" via [rollback]. Case II ---- **Edit 4 - Admin; manual revert to version #0** Edit 3 - Vandal; vandalism Edit 2 - Bot; null edit (=version #1) Edit 1 - Vandal; vandalism Edit 0 - Editor; OK version Rollback was not an option for Admin since they noticed the vandalism from #1 too. Ideally edit #4 could be "Reverted edits by Vandal to last version by Editor)" via [rollback]. This won't handle the case were the edits were from two different vandals, but it could at least detect that they are the same. This could probably make use of rev_sha1. For case #1, history would need to show [rollback] links for the last non-null revision. Ideally, recentchanges too, but that would probably be too expensive.

Inspired by T169457... There are at least two cases where rollback and null edits (e.g. protection events) do not interact well. Suppose "Bot" is a page-protection bot (it could also be a Sysop doing that manually and missing the vandalism). Any log-type null-edit generating event will do. Case I ---- **Edit 3 - Admin; manual revert to version #0** Edit 2 - Bot; null edit (=version #1) Edit 1 - Vandal; vandalism Edit 0 - Editor; OK version Rollback was not an option for Admin here since rollback of #2 would try to revert Bot and go to #1. Those have the same text, so it would error out. Ideally edit #3 could be "Reverted edits by Vandal to last version by Editor)" via [rollback]. Case II ---- **Edit 4 - Admin; manual revert to version #0** Edit 3 - Vandal; vandalism Edit 2 - Bot; null edit (=version #1) Edit 1 - Vandal; vandalism Edit 0 - Editor; OK version Rollback was not an option for Admin since they noticed the vandalism from #1 too. Ideally edit #4 could be "Reverted edits by Vandal to last version by Editor)" via [rollback]. This won't handle the case were the edits were from two different vandals, but it could at least detect that they are the same. Since this is relatively rare DB traffic wiseThis could probably make use of rev_sha1. For case #1, history would need to show [rollback] links for the last non-null revision. Ideally, it could be done in loops of the current coderecentchanges too, checking rev_sha1 and moving further down (both for "bad user" selection and "last different version by someone else"but that would probably be too expensive.