Change Details

Question: Practically, are we planning to build the new search in core or Vector? Outcome:https://phabricator.wikimedia.org/T244392 is updated with the outcome of this discussion = background Currently the search widget is in core and is loaded by a core module based on the existence of an element with a given ID in the HTML. If we change that ID we break gadgets so we can’t do that. https://github.com/wikimedia/mediawiki/blob/bbb7beab650bf490c9bf1d884b4a949ced1ae2fc/resources/src/mediawiki.page.ready/ready.js#L87 Minerva is the only skin that turns this off and the only reason it is able to do this is it doesn’t load mediawiki.page.ready (which also turns off sortable tables and collapsible elements) which is not an option for Vector. See open bug T111565 for more context. If we’re planning to build the new search in Vector I guess we’ll need to make some architectural changes in core to support that. Although I can see a lot of benefits of doing this in core too = Questions to answer 1. Should the new search component be built in core, Vector or a standalone repo? 2. What changes in core are needed to support Vector (and in future Minerva) changing the search implementation? 3. What does the roadmap look like for removing the existing code? Should we plan to make the new search component apply to all skins or will we retain the old code? Where will that code live? Who will maintain it? = Signoff criteria [] Communicate recommendations from this task to FAWG and other stakeholders and document results

Question: Practically, are we planning to build the new search in core or Vector? Outcome:https://phabricator.wikimedia.org/T244392 is updated with the outcome of this discussion = background Currently the search widget is in core and is loaded by a core module based on the existence of an element with a given ID in the HTML. If we change that ID we break gadgets so we can’t do that. https://github.com/wikimedia/mediawiki/blob/bbb7beab650bf490c9bf1d884b4a949ced1ae2fc/resources/src/mediawiki.page.ready/ready.js#L87 Minerva is the only skin that turns this off and the only reason it is able to do this is it doesn’t load mediawiki.page.ready (which also turns off sortable tables and collapsible elements) which is not an option for Vector. See open bug T111565 for more context. If we’re planning to build the new search in Vector I guess we’ll need to make some architectural changes in core to support that. Although I can see a lot of benefits of doing this in core too = Questions to answer 1. Should the new search component be built in core, Vector or a standalone repo? 2. What changes in core are needed to support Vector (and in future Minerva) changing the search implementation? 3. What does the roadmap look like for removing the existing code? Should we plan to make the new search component apply to all skins or will we retain the old code? Where will that code live? Who will maintain it? = Signoff criteria [] Communicate recommendations from this task to FAWG, WMDE (@WMDE-leszek and @Pablo-WMDE may be good contacts), and other stakeholders and document results

Question: Practically, are we planning to build the new search in core or Vector? Outcome:https://phabricator.wikimedia.org/T244392 is updated with the outcome of this discussion = background Currently the search widget is in core and is loaded by a core module based on the existence of an element with a given ID in the HTML. If we change that ID we break gadgets so we can’t do that. https://github.com/wikimedia/mediawiki/blob/bbb7beab650bf490c9bf1d884b4a949ced1ae2fc/resources/src/mediawiki.page.ready/ready.js#L87 Minerva is the only skin that turns this off and the only reason it is able to do this is it doesn’t load mediawiki.page.ready (which also turns off sortable tables and collapsible elements) which is not an option for Vector. See open bug T111565 for more context. If we’re planning to build the new search in Vector I guess we’ll need to make some architectural changes in core to support that. Although I can see a lot of benefits of doing this in core too = Questions to answer 1. Should the new search component be built in core, Vector or a standalone repo? 2. What changes in core are needed to support Vector (and in future Minerva) changing the search implementation? 3. What does the roadmap look like for removing the existing code? Should we plan to make the new search component apply to all skins or will we retain the old code? Where will that code live? Who will maintain it? = Signoff criteria [] Communicate recommendations from this task to FAWG, WMDE (@WMDE-leszek and @Pablo-WMDE may be good contacts), and other stakeholders and document results