Change Details

It seems that the seek param of thumbor is no longer working as expected. A url like: https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2.5-Parus_major,_Germany_2009.ogv.jpg should return an image from 2.5 seconds into the movie [[ https://commons.wikimedia.org/wiki/File:Parus_major,_Germany_2009.ogv | File:Parus_major,_Germany_2009.ogv ]] but instead it shows the midway frame of the video. This used to work... Actually it seems https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2-Parus_major,_Germany_2009.ogv.jpg still works, so it's the floating point parsing that this fails on.. https://phabricator.wikimedia.org/diffusion/THMBREXT/browse/master/wikimedia_thumbor/loader/video/__init__.py$163 has int() which does indeed fail on floating numbers.

It seems that the seek param of thumbor is no longer working as expected. A url like: https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2.5-Parus_major,_Germany_2009.ogv.jpg should return an image from 2.5 seconds into the movie [[ https://commons.wikimedia.org/wiki/File:Parus_major,_Germany_2009.ogv | File:Parus_major,_Germany_2009.ogv ]] but instead it shows the midway frame of the video. This used to work... Actually it seems https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2-Parus_major,_Germany_2009.ogv.jpg still works, so it's the floating point parsing that this fails on.. https://phabricator.wikimedia.org/diffusion/THMBREXT/browse/master/wikimedia_thumbor/loader/video/__init__.py$163 has int() which does indeed fail on floating numbers. Having subsecond thumbtimes is actually useful, as there can be 24 up to 60 frames in a second and this frame picking can definitely make a big difference.

It seems that the seek param of thumbor is no longer working as expected. A url like: https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2.5-Parus_major,_Germany_2009.ogv.jpg should return an image from 2.5 seconds into the movie [[ https://commons.wikimedia.org/wiki/File:Parus_major,_Germany_2009.ogv | File:Parus_major,_Germany_2009.ogv ]] but instead it shows the midway frame of the video. This used to work... Actually it seems https://upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Parus_major,_Germany_2009.ogv/300px-seek=2-Parus_major,_Germany_2009.ogv.jpg still works, so it's the floating point parsing that this fails on.. https://phabricator.wikimedia.org/diffusion/THMBREXT/browse/master/wikimedia_thumbor/loader/video/__init__.py$163 has int() which does indeed fail on floating numbers. Having subsecond thumbtimes is actually useful, as there can be 24 up to 60 frames in a second and this frame picking can definitely make a big difference.