Change Details

I6f44e3e5d (https://gerrit.wikimedia.org/r/#/c/239649/) introduces an improved personal toolbar for logged-out users. The patch adds a text to the list of links in the Personal Tools. I would argue that "Not logged in" is not a personal tool, but some kind of status information. So this patch mixes things that should not be mixed. Instead it would have been better if it had been left to the actual skin to signal the "Not logged in" state to the user. {F3401844} {F3401846} As it is this patch breaks styling on skins that expect actual links in the Personal Tools. {F3401849} See also T112724

I6f44e3e5d (https://gerrit.wikimedia.org/r/#/c/239649/) introduces an improved personal toolbar for logged-out users. The patch adds a text to the list of links in the Personal Tools. I would argue that "Not logged in" is not a personal tool, but some kind of status information. So this patch mixes things that should not be mixed. Instead it would have been better if it had been left to the actual skin to signal the "Not logged in" state to the user. {F3401844} {F3401846} As it is this patch introduces unwanted text and breaks styling on skins that expect actual links in the Personal Tools. {F3401849} See also T112724

I6f44e3e5d (https://gerrit.wikimedia.org/r/#/c/239649/) introduces an improved personal toolbar for logged-out users. The patch adds a text to the list of links in the Personal Tools. I would argue that "Not logged in" is not a personal tool, but some kind of status information. So this patch mixes things that should not be mixed. Instead it would have been better if it had been left to the actual skin to signal the "Not logged in" state to the user. {F3401844} {F3401846} As it is this patch introduces unwanted text and breaks styling on skins that expect actual links in the Personal Tools. {F3401849} See also T112724