Change Details

The table in question is `wikishared.reading_list` on x1. It is a shared table used by all wikis, and the code handling it is not exposed to traffic yet so it's practically empty (400 rows). Some time next week it will get beta tester traffic. {T187226} requires a new column to be added: ```lang=sql ALTER TABLE /*_*/reading_list ADD COLUMN rl_size INTEGER UNSIGNED NOT NULL DEFAULT 0; ``` ([[https://gerrit.wikimedia.org/r/#/c/410653/3/sql/patches/06-add-rl_size.sql|patchfile]]) This change does not affect existing code and can be deployed at any time. ---- {T184680} requires an index change: ```lang=sql ALTER IGNORE TABLE reading_list MODIFY rl_name VARCHAR(255) BINARY, DROP INDEX rl_user_deleted_name_id, ADD UNIQUE INDEX rl_user_deleted_name (rl_user_id, rl_deleted, rl_name), DROP INDEX rl_user_name_id, ADD UNIQUE INDEX rl_user_name (rl_user_id, rl_name); ``` ([[https://gerrit.wikimedia.org/r/#/c/412844/3/sql/patches/07-add-index-rl_user_name.sql|patchfile]]) This change will break existing code very slightly. (Attempts to create multiple lists with the same name will result in a duplicate key DB error; the corresponding patch will change that to a soft error. Also, creation of a new list with the same name as the deleted list will result in a duplicate key error; the patch will handle that situation correctly.) ReadingLists is not-even-beta and not exposed to any real users so that's not considered a problem. If the two schema changes are done separately, I can deploy the patch between them (can't do it now as it depends on the first schema change), if they are done together just tell me when so I can do the code deploy later that day.

The table in question is `wikishared.reading_list` on x1. It is a single shared table used by all wikis, and the code handling it is not exposed to traffic yet so it's practically empty (400 rows) and probably gets approximately zero requests per minute, so if you feel DBA attention is not required I can run the queries. Some time next week it will get beta tester traffic though. {T187226} requires a new column to be added: ```lang=sql ALTER TABLE /*_*/reading_list ADD COLUMN rl_size INTEGER UNSIGNED NOT NULL DEFAULT 0; ``` ([[https://gerrit.wikimedia.org/r/#/c/410653/3/sql/patches/06-add-rl_size.sql|patchfile]]) This change does not affect existing code and can be deployed at any time. ---- {T184680} requires an index change: ```lang=sql ALTER IGNORE TABLE reading_list MODIFY rl_name VARCHAR(255) BINARY, DROP INDEX rl_user_deleted_name_id, ADD UNIQUE INDEX rl_user_deleted_name (rl_user_id, rl_deleted, rl_name), DROP INDEX rl_user_name_id, ADD UNIQUE INDEX rl_user_name (rl_user_id, rl_name); ``` ([[https://gerrit.wikimedia.org/r/#/c/412844/3/sql/patches/07-add-index-rl_user_name.sql|patchfile]]) This change will break existing code very slightly. (Attempts to create multiple lists with the same name will result in a duplicate key DB error; the corresponding patch will change that to a soft error. Also, creation of a new list with the same name as the deleted list will result in a duplicate key error; the patch will handle that situation correctly.) ReadingLists is not-even-beta and not exposed to any real users so that's not considered a problem. If the two schema changes are done separately, I can deploy the patch between them (can't do it now as it depends on the first schema change), if they are done together just tell me when so I can do the code deploy later that day.

The table in question is `wikishared.reading_list` on x1. It is a single shared table used by all wikis, and the code handling it is not exposed to traffic yet so it's practically empty (400 rows) and probably gets approximately zero requests per minute, and the code handling it is not exposed to traffic yet so it's practically empty (400 rows)so if you feel DBA attention is not required I can run the queries. Some time next week it will get beta tester traffic though. {T187226} requires a new column to be added: ```lang=sql ALTER TABLE /*_*/reading_list ADD COLUMN rl_size INTEGER UNSIGNED NOT NULL DEFAULT 0; ``` ([[https://gerrit.wikimedia.org/r/#/c/410653/3/sql/patches/06-add-rl_size.sql|patchfile]]) This change does not affect existing code and can be deployed at any time. ---- {T184680} requires an index change: ```lang=sql ALTER IGNORE TABLE reading_list MODIFY rl_name VARCHAR(255) BINARY, DROP INDEX rl_user_deleted_name_id, ADD UNIQUE INDEX rl_user_deleted_name (rl_user_id, rl_deleted, rl_name), DROP INDEX rl_user_name_id, ADD UNIQUE INDEX rl_user_name (rl_user_id, rl_name); ``` ([[https://gerrit.wikimedia.org/r/#/c/412844/3/sql/patches/07-add-index-rl_user_name.sql|patchfile]]) This change will break existing code very slightly. (Attempts to create multiple lists with the same name will result in a duplicate key DB error; the corresponding patch will change that to a soft error. Also, creation of a new list with the same name as the deleted list will result in a duplicate key error; the patch will handle that situation correctly.) ReadingLists is not-even-beta and not exposed to any real users so that's not considered a problem. If the two schema changes are done separately, I can deploy the patch between them (can't do it now as it depends on the first schema change), if they are done together just tell me when so I can do the code deploy later that day.