Change Details

I submitted [[https://gerrit.wikimedia.org/r/#/c/393080/|a (WIP-ish, unmerged) patchset against RelatedArticles]] but jerkins is downvoting it consistently; it seemed to me that the failure was entirely unrelated to my patch, which was confirmed my @legoktm's [[https://gerrit.wikimedia.org/r/#/c/393425/|test patch against RelatedArticle's README file]], which obviously in no way could have caused the tests to fail.

Unit tests were not running by default in Minerva - only when you run `check experimental` does Jenkins bother to run them. This is being fixed in T181429. Some how a unit test got broken and is blocking merges elsewhere. = Developer notes * 2 unit tests are breaking and relate to the NotificationBadge. * this.setCount is not called if `el` option is not provided. It looks like calling setCount before running the test should be sufficient to fix this. = Original report I submitted [[https://gerrit.wikimedia.org/r/#/c/393080/|a (WIP-ish, unmerged) patchset against RelatedArticles]] but jerkins is downvoting it consistently; it seemed to me that the failure was entirely unrelated to my patch, which was confirmed my @legoktm's [[https://gerrit.wikimedia.org/r/#/c/393425/|test patch against RelatedArticle's README file]], which obviously in no way could have caused the tests to fail.

Unit tests were not running by default in Minerva - only when you run `check experimental` does Jenkins bother to run them. This is being fixed in T181429. Some how a unit test got broken and is blocking merges elsewhere. = Developer notes * 2 unit tests are breaking and relate to the NotificationBadge. * this.setCount is not called if `el` option is not provided. It looks like calling setCount before running the test should be sufficient to fix this. = Original report I submitted [[https://gerrit.wikimedia.org/r/#/c/393080/|a (WIP-ish, unmerged) patchset against RelatedArticles]] but jerkins is downvoting it consistently; it seemed to me that the failure was entirely unrelated to my patch, which was confirmed my @legoktm's [[https://gerrit.wikimedia.org/r/#/c/393425/|test patch against RelatedArticle's README file]], which obviously in no way could have caused the tests to fail.