Maniphest T100405

Do not load icons without JS
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 26 2015, 9:07 AM

Tags

Referenced Files

None

Subscribers

Description

The following icons are only needed with JS enabled:

Page actions icons:
.mw-ui-icon-watch-invert:before
.mw-ui-icon-watched:before
.mw-ui-icon-watched-invert:before
.mw-ui-icon-edit-invert:before
.mw-ui-icon-edit-enabled-invert:before

Overlay icons:
.mw-ui-icon-previous:before
.mw-ui-icon-previous-invert:before
.mw-ui-icon-next:before
.mw-ui-icon-next-invert:before

We should thus make these separate icon RL module packs.

Details

	Subject	Repo	Branch	Lines +/-
	Icons in beta should be loaded via JavaScript	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Duplicate		• Jhernandez	T104432 [EPIC]: Improve mobile site performance
		Resolved		Jdlrobson	T98986 [EPIC] Improve the status quo of mobile web performance
		Duplicate		None	T98397 Main menu and notification css should be loaded via JavaScript
		Duplicate		None	T98987 Epic: Make mobile web more performant
		Resolved		Jdlrobson	T97289 Trim down CSS loaded in the head for anonymous users on mobile
		Resolved		Jdlrobson	T100405 Do not load icons without JS

Event Timeline

Jdlrobson created this task.May 26 2015, 9:07 AM

Jdlrobson assigned this task to • Gilles.

Jdlrobson raised the priority of this task from to Medium.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Performance-Team, Web-Team-Backlog, MobileFrontend.

Jdlrobson updated the task description. (Show Details)

Jdlrobson set Security to None.

Jdlrobson added subscribers: Volker_E, Florian, Jdlrobson and 4 others.

Jdlrobson removed • Gilles as the assignee of this task.May 26 2015, 10:40 AM

Jdlrobson moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog board.

Jdlrobson moved this task from 2017-18 Q3 to Incoming on the Web-Team-Backlog board.

Change 213985 had a related patch set uploaded (by Jdlrobson):
Icons in beta should be loaded via JavaScript

https://gerrit.wikimedia.org/r/213985

gerritbot added a project: Patch-For-Review.May 27 2015, 6:26 AM

Jdlrobson claimed this task.May 27 2015, 6:30 PM

Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.

Change 213985 merged by jenkins-bot:
Icons in beta should be loaded via JavaScript

https://gerrit.wikimedia.org/r/213985

Jdlrobson mentioned this in rEMFRec04d21d3d7d: Icons in beta should be loaded via JavaScript.May 27 2015, 7:48 PM

Diffusion mentioned this in rMEXT4759b0d5461f: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 27 2015, 7:48 PM

Jdlrobson closed this task as Resolved.May 27 2015, 7:52 PM

Krinkle edited projects, added Performance Issue; removed Performance-Team.Jun 23 2015, 5:26 AM

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:25 AM