Page MenuHomePhabricator
Create Task
Maniphest T100779

pywikibot api paraminfo should to recover from defective API modules
Closed, ResolvedPublic
Actions

Description

If loading the initialisation of ParamInfo was successful, some of the core API modules are working correctly.
If then loading a batch of modules causes a server error, the paraminfo class could retry the batch by loading paraminfo for one module at a time, and report which module fails.

Another option is to avoid loading non-core modules, or avoid loading all modules to determine prefixes.

This should make pywikibot more resilient for when defective modules deployed to a wiki, and result in quicker & better errors reported to WMF ops / release managers.

(Currently WMF test and beta wikis have such a defective module : T100775 , so fixing this quickly may be necessary in case Wikimedia dont revert / fix the problem)

Details

SubjectRepoBranchLines +/-
Deprecate ParamInfo.query_modules_with_limitspywikibot/core2.0+29 -8
Deprecate ParamInfo.query_modules_with_limitspywikibot/coremaster+29 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

jayvdb created this task.May 29 2015, 11:12 AM
jayvdb raised the priority of this task from to Unbreak Now!.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Pywikibot-tests, Pywikibot.
jayvdb added subscribers: greg, Unknown Object (MLST), jayvdb, Aklapper.
XZise subscribed.May 29 2015, 11:30 AM

The problem would be that other parts usually rely on the fact that after the fetch call all modules are now cached.

greg added a comment.May 29 2015, 3:57 PM

Given T100775 is fixed, I think there's nothing else for me here (this task is for a pywikibot-specific issue, yes?), so unusbscribing. Thanks for the heads up though.

greg unsubscribed.May 29 2015, 3:57 PM
XZise added a comment.May 29 2015, 8:17 PM

Okay if we are going to change something for this I think the most sensible way would be to have a flag in fetch() to ignore failures. And whenever a batch is executed and it's not important that all modules are cached and it “could“ skip some that it skips problematic.

Ladsgroup mentioned this in T101214: Decommission compat.Jun 3 2015, 9:06 AM
XZise lowered the priority of this task from Unbreak Now! to Needs Triage.Jun 3 2015, 10:08 AM
XZise set Security to None.
jayvdb triaged this task as Medium priority.Jun 3 2015, 10:34 AM
Ricordisamoa subscribed.Jun 3 2015, 2:43 PM
jayvdb moved this task from Backlog to Upstream issues on the Pywikibot-tests board.Jun 9 2015, 6:25 AM
XZise mentioned this in T108317: paraminfo for flow submodule view-topic-history fails.Aug 7 2015, 1:38 PM
jayvdb mentioned this in T108322: prevent modules with broken paraminfo being deployed to production wikis.Aug 7 2015, 1:54 PM
gerritbot subscribed.Sep 5 2015, 5:52 AM

Change 236246 had a related patch set uploaded (by John Vandenberg):
Deprecate ParamInfo.query_modules_with_limits

https://gerrit.wikimedia.org/r/236246

gerritbot added a project: Patch-For-Review.Sep 5 2015, 5:52 AM
gerritbot added a comment.Sep 23 2015, 2:17 PM

Change 236246 merged by jenkins-bot:
Deprecate ParamInfo.query_modules_with_limits

https://gerrit.wikimedia.org/r/236246

jayvdb mentioned this in rPWBC879defd1fd5e: Deprecate ParamInfo.query_modules_with_limits.Sep 23 2015, 2:17 PM
gerritbot added a comment.Oct 1 2015, 11:32 PM

Change 243060 had a related patch set uploaded (by John Vandenberg):
Deprecate ParamInfo.query_modules_with_limits

https://gerrit.wikimedia.org/r/243060

gerritbot added a comment.Oct 2 2015, 9:05 PM

Change 243060 merged by jenkins-bot:
Deprecate ParamInfo.query_modules_with_limits

https://gerrit.wikimedia.org/r/243060

jayvdb mentioned this in rPWBC1d36e45ec25e: Deprecate ParamInfo.query_modules_with_limits.Oct 2 2015, 9:07 PM
Magul removed a project: Patch-For-Review.Nov 15 2016, 9:14 PM
Xqt closed this task as Resolved.Sep 20 2023, 7:13 AM
Xqt claimed this task.
Xqt subscribed.

This task is not clear to me and the description is not reproducable. So closing it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL