Maniphest T101308

Ex:WikidataQualityConstraints - EntityId::getSerialization() is not guaranteed to be safe for HTML
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• csteipp
	Jun 3 2015, 8:48 PM

Tags

Referenced Files

None

Subscribers

Andreasburmeister

Lydia_Pintscher

Description

In SpecialConstraintReport::buildResultHeader(), $entityId->getSerialization() needs to be escaped before adding to html

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T99354 Review and deploy Wikibase-Quality-Constraints on wikidata.org
		Resolved		• csteipp	T99355 Security review of Wikibase-Quality-Constraints - v1 branch
		Resolved		dominic.sauer	T101308 Ex:WikidataQualityConstraints - EntityId::getSerialization() is not guaranteed to be safe for HTML

Event Timeline

• csteipp created this task.Jun 3 2015, 8:48 PM

• csteipp raised the priority of this task from to Needs Triage.

• csteipp updated the task description. (Show Details)

• csteipp added projects: Wikidata, Wikibase-Quality-Constraints, deprecated-security-team-reviews.

• csteipp added subscribers: Andreasburmeister, • csteipp, Tamslo and 4 others.

• csteipp mentioned this in T99355: Security review of Wikibase-Quality-Constraints - v1 branch.Jun 3 2015, 8:52 PM

• csteipp removed a project: deprecated-security-team-reviews.Jun 4 2015, 11:58 PM

• csteipp set Security to None.

soeren.oldag closed this task as Resolved.Jun 5 2015, 9:34 AM

soeren.oldag assigned this task to dominic.sauer.

Gerrit-Change: https://gerrit.wikimedia.org/r/#/c/216047/

See my comment on the gerrit patch

Change 216405 had a related patch set uploaded (by Soeren.oldag):
Serialization of entity ids is now escaped correctly.

https://gerrit.wikimedia.org/r/216405

gerritbot added a project: Patch-For-Review.Jun 6 2015, 9:03 AM

Change 216405 merged by Jonaskeutel:
Serialization of entity ids is now escaped correctly.

https://gerrit.wikimedia.org/r/216405

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jun 10 2015, 6:36 AM

Lydia_Pintscher triaged this task as High priority.Jun 12 2015, 1:15 PM

Fix looks correct

Liuxinyu970226 unsubscribed.Jun 12 2015, 11:34 PM

Aklapper removed a subscriber: Wikibase-Quality-Constraints.May 16 2023, 10:25 AM

Maintenance_bot removed a project: Patch-For-Review.May 16 2023, 10:35 AM