Page MenuHomePhabricator

Automatic Cite generation results in malformed URL after fed valid LeMonde.fr link
Closed, ResolvedPublic

Description

When feeding the Automatic Cite tool a valid URL (http://www.lemonde.fr/culture/article/2013/09/28/arturo-brachetti-dans-son-repaire-a-turin_3486315_3246.html), the tool receives and fills in mostly correct information, except the URL is missing "http://www.lemonde.fr".

Article/edit discovered on: https://en.wikipedia.org/w/index.php?diff=665665653

Browser: Chrome

Steps:

  1. Open article with Visual Editor
  2. Place cursor inside article and click Cite button.
  3. Paste http://www.lemonde.fr/culture/article/2013/09/28/arturo-brachetti-dans-son-repaire-a-turin_3486315_3246.html into the URL field and click Generate.
  4. Click Insert.
  5. Select the new footnote and inspect URL field.

Result: The URL is now malformed and shows only: /culture/article/2013/09/28/arturo-brachetti-dans-son-repaire-a-turin_3486315_3246.html

Event Timeline

Stesmo raised the priority of this task from to Needs Triage.
Stesmo updated the task description. (Show Details)
Stesmo added a project: VisualEditor.
Stesmo moved this task to To Triage on the VisualEditor board.
Stesmo subscribed.
Stesmo set Security to None.

This is due to a broken Zotero translator, filed here: https://github.com/zotero/translators/issues/904

We could validate URLs in citoid to make sure they're fully qualified though.

Mvolz added a subscriber: mobrovac.

Resolved in translators: https://github.com/zotero/translators/commit/57e87730f7c38953168c2fa2694940806e62587d

We'll need to update our own translator repo to pull this through, @mobrovac?

Yup. I'm thinking we should bundle this deploy together with T101683: Poor results from wiley online

Change 218345 had a related patch set uploaded (by Mvolz):
Update translators and enable Wiley translator

https://gerrit.wikimedia.org/r/218345

Change 218345 merged by Mobrovac:
Update translators and enable Wiley translator

https://gerrit.wikimedia.org/r/218345

mobrovac claimed this task.

Deployed and checked, it's not fixed. Resolving.

mobrovac removed a subscriber: gerritbot.

.. it's not fixed.

I meant to say it's now fixed :)

Change 229368 had a related patch set uploaded (by Mvolz):
[WIP] Validate Zotero url

https://gerrit.wikimedia.org/r/229368