Maniphest T102031

Reduce number of RL modules
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Jun 10 2015, 6:32 PM

Description

We have an obscene number of RL modules; I count 1196 on enwiki right now. I broke these down into groups based on prefix, so we can look at where the biggest problems are:

P757 RL module counts on enwiki

1	145 jquery
2	31 jquery.ui
3	21 jquery.valueview
4	14 jquery.effects
5	8 jquery.wikiEditor
6	4 jquery.uls
7	3 jquery.wikibase
8	2 jquery.util
9	2 jquery.qunit
10	60 (other)
11	143 ext.geshi
12	126 mediawiki
13	26 mediawiki.special
14	15 mediawiki.action
15	8 mediawiki.ui
16	8 mediawiki.api
17	7 mediawiki.legacy
18	6 mediawiki.page
19	6 mediawiki.language
20	5 mediawiki.skinning
21	4 mediawiki.template
22	3 mediawiki.messagePoster
23	3 mediawiki.libs
24	3 mediawiki.htmlform
25	2 mediawiki.jqueryMsg
26	2 mediawiki.debug
27	28 (other)
28	103 wikibase
29	51 wikibase.serialization
30	33 wikibase.datamodel
31	7 wikibase.client
32	6 wikibase.api
33	6 (other)
34	79 mobile
35	66 ext.gadget
36	51 mmv
37	45 schema
38	33 ext.math
39	30 mw
40	29 skins
41	27 ext.visualEditor
42	24 ext.gather
43	21 ext.uls
44	21 ext.flow
45	21 ep
46	19 oojs-ui
47	11 ext.pageTriage
48	11 ext.guidedTour
49	11 ext.centralauth
50	9 util
51	9 ext.MassMessage
52	8 ext.gettingstarted
53	8 ext.centralNotice
54	7 ext.wikiEditor
55	6 user
56	6 ext.echo
57	5 ext.wikiLove
58	4 valueParsers
59	4 valueFormatters
60	4 ext.thanks
61	4 ext.globalCssJs
62	4 ext.collection
63	4 ext.codeEditor
64	4 ext.abuseFilter
65	3 ext.wikihiero
66	3 ext.templateDataGenerator
67	3 ext.scribunto
68	3 ext.MWOAuth
69	3 ext.imageMetrics
70	3 ext.flaggedRevs
71	3 ext.eventLogging
72	3 ext.confirmEdit
73	3 ext.betaFeatures
74	3 dataValues
75	2 unicodejs
76	2 time
77	2 ext.wikimediaEvents
78	2 ext.securepoll
79	2 ext.inputBox
80	2 ext.graph
81	2 ext.categoryTree
82	2 ext.apifeatureusage
83	2 easy-deflate
84	2 dataTypes
85	1 zerobanner
86	1 tablet
87	1 Spinner
88	1 site
89	1 rangy
90	1 rangefix
91	1 qunit
92	1 pdfhandler
93	1 papaparse
94	1 oojs
95	1 noscript
96	1 moment
97	1 json
98	1 iScroll
99	1 globeCoordinate
100	1 fullScreenApi
101	1 filepage
102	1 ext.wikimediamessages
103	1 ext.wikimediaBadges
104	1 ext.vipsscaler
105	1 ext.tmh
106	1 ext.TemplateSandbox
107	1 ext.templateData
108	1 ext.rtlcite
109	1 ext.popups
110	1 ext.nuke
111	1 ext.navigationTiming
112	1 ext.interwiki
113	1 ext.GlobalUserPage
114	1 ext.dismissableSiteNotice
115	1 ext.disambiguator
116	1 ext.citoid
117	1 ext.citeThisPage
118	1 ext.cite
119	1 ext.cirrusSearch
120	1 ext.checkUser
121	1 ext.campaigns
122	1 ext.babel
123	1 ext.apiSandbox
124	1 es5-shim
125	1 embedPlayerIframeStyle
126	1 dom-level2-shim
127	1 dependencies
128	1 Base64

Main culprits IMO:

ext.geshi has one module per syntax highlighting language. I'm not sure how avoidable that is; maybe we can come up with a way to do parameterized modules here, or maybe we can make disable most of the 142 supported languages in wmf-config
wikibase appears to have one module per class, plus foo.__namespace modules; there could be some easy gains here by combining modules whose separation isn't needed in practice
The same pattern, at a smaller scale, appears to be happening in mmv (MultimediaViewer)
There are 79 mobile.* modules; there doesn't seem to be a clear pattern or one clear offender, but I suppose we could ask the mobile web team to see if things can be trimmed there

Smaller things:

There are 61 modules with 'style' in their name; not all of them are addModuleStyles-only, but some of them are, and those we could avoid listing in the startup module
We could audit to see if all 45 schema modules are in use
I'm unconvinced that extensions like VE, Gather, ULS, Flow and EducationProgram really need 20-30 modules each, those could be audited and trimmed too

Related Objects
Search...

Status	Assigned	Task
Resolved	• Gilles	T102031 Reduce number of RL modules
Resolved	ori	T85794 Convert SyntaxHighlight_Geshi from Geshi to Pygments (was: Don't register 250+ modules)
Resolved	• Gilles	T103706 Reduce number of RL modules in MultimediaViewer

Event Timeline

Catrope created this task.Jun 10 2015, 6:32 PM

Catrope raised the priority of this task from to Needs Triage.

Catrope updated the task description. (Show Details)

Catrope added projects: Performance Issue, Performance-Team.

Catrope added subscribers: Catrope, ori, Krinkle.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2015, 6:32 PM

Krinkle added a subtask: T85794: Convert SyntaxHighlight_Geshi from Geshi to Pygments (was: Don't register 250+ modules).Jun 10 2015, 7:43 PM

ext.geshi has one module per syntax highlighting language. I'm not sure how avoidable that is

It is very much avoidable. It must be. The current implementation of Geshi is unnecessarily complex and verbose. Any sane syntax highlighter separates grammar and styling. Geshi does not. See T85794 for various ideas.

There are 61 modules with 'style' in their name; not all of them are addModuleStyles-only, but some of them are, and those we could avoid listing in the startup module

This is blocked by T92459 and associated tasks, which will make it possible to add "state:ready" calls for style modules in the html. However excluding styles-only modules from the startup module is probably not an option. They are still eligible for lazy-loading and depending on. E.g. loading diff styles in VE.

Legoktm subscribed.Jun 10 2015, 7:57 PM

Krinkle triaged this task as Medium priority.Jun 10 2015, 10:27 PM

Krinkle moved this task from Tag to Next-up on the Performance Issue board.

Krinkle set Security to None.

In T102031#1354378, @Krinkle wrote:

There are 61 modules with 'style' in their name; not all of them are addModuleStyles-only, but some of them are, and those we could avoid listing in the startup module

This is blocked by T92459 and associated tasks, which will make it possible to add "state:ready" calls for style modules in the html. However excluding styles-only modules from the startup module is probably not an option. They are still eligible for lazy-loading and depending on. E.g. loading diff styles in VE.

Yeah, I didn't mean style-only modules, but specifically modules that are only ever used with addModuleStyles(). That's probably too complex to track and too small to be helpful, though.

Ltrlg subscribed.Jun 11 2015, 7:24 PM

Krinkle moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.Jun 18 2015, 12:05 AM

Jdforrester-WMF closed subtask T85794: Convert SyntaxHighlight_Geshi from Geshi to Pygments (was: Don't register 250+ modules) as Resolved.Jun 24 2015, 10:37 PM

He7d3r awarded a token.Jul 9 2015, 4:31 PM

He7d3r subscribed.

matmarex closed subtask T103706: Reduce number of RL modules in MultimediaViewer as Resolved.Jul 15 2015, 11:23 PM

Krinkle lowered the priority of this task from Medium to Low.Jul 31 2015, 6:21 AM

Krinkle moved this task from To-do: Goals prioritized current Quarter to Backlog: Maintenance, non-prioritized on the Performance-Team board.

Krinkle moved this task from Next-up to Tag on the Performance Issue board.Aug 29 2015, 12:35 AM

Updated overview (from enwiki)

469	"ext"
	82	"gadget"
	57	"cx"
	33	"visualEditor"
	21	"kartographer"
	20	"uls"
	18	"RevisionSlider"
	17	"centralNotice"
	15	"echo"
	14	"tmh"
	14	"centralauth"
	13	"guidedTour"
	11	"pageTriage"

168	"mediawiki"
	33	"special"
	16	"action"
	12	"api"

146	"jquery"
	32	"ui"
	24	"valueview" # Wikidata
	14	"effects"

104	"wikibase"
	51	"serialization"
	33	"datamodel"
	8	"client"
	6	"api"

70	"mobile"
	6	"app"
	4	"search"
	4	"special"

42	"schema"
	# EventLogging

38	"mw"
	# CX and TMH

27	"skins"
	21	"minerva"
	3	"vector"

21	"ep"

19	"oojs-ui"

9	"mmv"

9	"util"
	# Wikidata

• Gilles closed this task as Resolved.Dec 7 2016, 9:04 PM

• Gilles claimed this task.

Reduce number of RL modulesClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Reduce number of RL modules
Closed, ResolvedPublic
Actions

Related Objects
Search...