Maniphest T104033

Populate rev_content_model and rev_content_format when saving
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Legoktm
	Jun 26 2015, 10:47 PM

Tags

Referenced Files

None

Subscribers

View All 9 Subscribers

Description

We currently don't populate rev_content_* when saving if they are the default in order to save space, however this prevents changing of the default.

Related Objects

Mentioned In: T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage
T105245: <flow-action-unsupported> on any action
T73163: Cannot edit old revisions if the content model of those revisions are different from the page's current revision
Mentioned Here: T174023: Implement MCR storage layer
T105652: RfC: Content model storage

Event Timeline

Legoktm created this task.Jun 26 2015, 10:47 PM

Legoktm claimed this task.

Legoktm raised the priority of this task from to Needs Triage.

Legoktm updated the task description. (Show Details)

Legoktm added projects: Collaboration-Team-Sprint-D-2015-06-30, Collaboration-Team-Triage, MediaWiki-ContentHandler.

Legoktm added subscribers: • Mattflaschen-WMF, Legoktm, Aklapper.

Change 221306 had a related patch set uploaded (by Legoktm):
Always populate rev_content_* fields when saving

https://gerrit.wikimedia.org/r/221306

gerritbot added a project: Patch-For-Review.Jun 26 2015, 10:47 PM

Legoktm added a project: MediaWiki-libs-Rdbms.Jun 26 2015, 10:55 PM

Legoktm set Security to None.

• DannyH added a project: Collaboration-Team-Sprint-E-Everywhere-2015-07-14.Jun 30 2015, 7:49 PM

• DannyH triaged this task as Medium priority.Jun 30 2015, 9:03 PM

• DannyH moved this task from Sprint E - ends July 14 to Needs Review on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.

Legoktm mentioned this in T73163: Cannot edit old revisions if the content model of those revisions are different from the page's current revision.Jun 30 2015, 10:47 PM

Ricordisamoa subscribed.Jun 30 2015, 11:09 PM

matthiasmullie moved this task from Needs Review to Code Review Started on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.Jul 2 2015, 10:21 AM

• Mattflaschen-WMF removed a parent task: T103388: E11. Write maintenance script to populate page.page_content_model, revision.rev_content_*, archive.ar_content_*.Jul 7 2015, 3:10 AM

Anomie mentioned this in T105245: <flow-action-unsupported> on any action.Jul 9 2015, 4:31 PM

Catrope removed a project: Collaboration-Team-Sprint-E-Everywhere-2015-07-14.Jul 10 2015, 5:36 PM

• DannyH moved this task from Untriaged to Current workboard on the Collaboration-Team-Triage board.Jul 22 2015, 6:54 PM

The complexity of this task has escalated to a schema change RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Content_model_storage

• DannyH moved this task from Current workboard to Ready for next sprint on the Collaboration-Team-Triage board.Jul 24 2015, 6:50 PM

• Mattflaschen-WMF moved this task from Ready for next sprint to Near-Term Interest on the Collaboration-Team-Triage board.Aug 7 2015, 10:08 PM

• DannyH moved this task from Near-Term Interest to Freezer on the Collaboration-Team-Triage board.Aug 21 2015, 5:25 PM

Smalyshev mentioned this in T128466: Frontpage of wikidata wiki of the vagrant role wikidata shows error mssage.Jun 30 2016, 5:42 PM

In T104033#1480395, @Catrope wrote:

The complexity of this task has escalated to a schema change RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Content_model_storage

The RFC has been approved and implemented:
T105652: RfC: Content model storage

What is the status of this task and https://gerrit.wikimedia.org/r/221306?

In T104033#3791121, @Krinkle wrote:

In T104033#1480395, @Catrope wrote:

The complexity of this task has escalated to a schema change RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Content_model_storage

The RFC has been approved and implemented:
T105652: RfC: Content model storage

What is the status of this task and https://gerrit.wikimedia.org/r/221306?

I don't know. @Legoktm, do you know?

Also, when you say the RFC was implemented, when/where did that happen? I can't find a link to a Gerrit change in the usual places.

Actually it was never implemented, because it was likely to just be extra work that MCR would then change again. And given the amount of progress on MCR so far it seems unlikely to make sense to do this separately. Does that sound right @daniel ?

Change 221306 abandoned by Legoktm:
Always populate rev_content_* fields when saving

Reason:
Obsolete

https://gerrit.wikimedia.org/r/221306

Krinkle edited projects, added MediaWiki-Page-editing; removed MediaWiki-libs-Rdbms.Jul 28 2018, 11:42 PM

Aklapper edited projects, added Growth-Team; removed Collaboration-Team-Triage.Oct 12 2019, 4:08 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2019, 4:10 AM

Use rev_content_format and rev_content_model is deprecated since 1.31, see https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/423060/ for when this was noted, and T174023: Implement MCR storage layer for more context