Page MenuHomePhabricator

mobile.site module should not be loaded in head
Closed, ResolvedPublic

Description

Run a test on webpagetest.org using Url: https://en.m.wikipedia.org/wiki/Facebook, From: New York, NY USA - Chrome - 3G with advanced settings chrome timeline enabled

When the job is finished you'll note a request to mobile.site happens after styles, startup module, central notice and jquery/mediawiki.
This shouldn't be blocking
http://www.webpagetest.org/result/150723_SY_1707/1/details/

Screen Shot 2015-07-23 at 3.28.18 PM.png (338×925 px, 70 KB)

Let's move it to the bottom of the page.

Event Timeline

Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from mobile.site module should probably not be loaded in head to mobile.site module should not be loaded in head.Aug 12 2015, 4:51 PM
Jdlrobson updated the task description. (Show Details)

@Jdlrobson is this still a valid task? I'm going to put it in next sprint. Can you confirm this is still the case and that we should fix it please?

Change 232861 had a related patch set uploaded (by Jdlrobson):
Make mobile site module position bottom.

https://gerrit.wikimedia.org/r/232861

This looks good. 232861 is currently V-2 because of T109593.

Change 232861 merged by jenkins-bot:
Make mobile site module position bottom.

https://gerrit.wikimedia.org/r/232861