Page MenuHomePhabricator
Create Task
Maniphest T107283

Use lib/ve/build/modules.json to build extension.json
Open, LowPublic
Actions

Description

Now that both core and ve-mw define manifests as json files, we should be able to remove the duplication of having core files listed in both modules.json and extension.json. This will probably require some upstream changes to modules.json as extension.json fragments some features further, e.g. image files are grouped together.

Related Objects

Event Timeline

Esanders created this task.Jul 29 2015, 1:17 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor-MediaWiki.
Esanders subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 29 2015, 1:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krenair added subscribers: Krenair, Legoktm.Jul 29 2015, 2:42 PM
Jdforrester-WMF triaged this task as Low priority.Jul 30 2015, 5:33 PM
Jdforrester-WMF added a project: Technical-Debt.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Aug 1 2015, 11:08 PM
Esanders merged a task: T149577: Ensure VE-core's modules.json groups are a subset of VE-MW's extension.json ones.Mar 5 2019, 7:31 PM
Esanders added a subscriber: Jdforrester-WMF.
In T149577#2756878, @Esanders wrote:

There are also core-specific modules, like the bulid and mobile groups, and libraries we already have in mw (jquery etc)

In T149577#2756949, @Esanders wrote:

I'd suggest creating a extension-ve-mw.json with ve-mw specific modules, then creating a grunt task to stitch together that file with bits of modules.json. We could specify which core modules to merge in with a "@coreModules" list on extension-ve-mw.json.

Unfortunately we can't add json comments to flag modules.json as a generated file :( (we can add a "@comment" property at the top though)

Esanders merged a task: T75964: Load VisualEditor file from modules.json as a manifest, rather than tediously copying it into extension.json.Mar 5 2019, 7:33 PM
Esanders added a comment.Mar 5 2019, 7:36 PM

Merged three versions of this ticket :)

Found T75964 after merging the last one here, so this one is becoming canonical, despite James being the first to report it

Esanders added a subscriber: Krinkle.Mar 5 2019, 7:37 PM
Esanders added a comment.Mar 5 2019, 7:42 PM

To further the goals of T202154 (reducing ResourceLoader module count) we could also whitelist modules which we actually need to be a public API, and flatten the others so they are never exposed to ResourceLoader.

VE currently creates 62 modules but probably needs about 10-20 of those to be independently loadable.

Krinkle added a project: Performance-Team (Radar).Mar 9 2019, 10:54 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
DannyS712 mentioned this in T291527: Merge single use VisualEditor ResourceLoader modules to reduce module count.Sep 21 2021, 9:32 PM
Krinkle removed a project: Performance-Team (Radar).Aug 18 2023, 8:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL