Maniphest T110183

[Task] Plaintext formatter should render unit
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Jonas
	Aug 25 2015, 2:26 PM

Tags

Referenced Files

None

Subscribers

Description

Plaintext formatter should render unit, because it is use by wikitext output. Quantity input should use a formatter option to get value without unit.

Caller Graph for Quantity input :

RepoApi < FormatValueCall < jquery.valueview.valueview < Snakview < statementview < TemplatedWidget

Details

	Subject	Repo	Branch	Lines +/-
	Revert plain text QuantityFormatter to output unit by default	mediawiki/extensions/Wikibase	master	+3 -16

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T56318 Quantity datatype (tracking)
		Resolved	Feature	Michael	T68580 Better support for exact values in Quantity DataType
		Resolved		daniel	T140997 When guessing quantity precision from digits, use the +/-0.5 rule rather than the +/-1 rule
		Open		None	T133042 Quantity datatype precision (tracking)
		Resolved		Lydia_Pintscher	T115269 [Story] When a Quantity is entered with no uncertainty/bounds given, do not guess uncertainty/bounds until needed.
		Resolved		thiemowmde	T115270 Allow QuantityValue objects to have empty/no bounds set
		Resolved		daniel	T105623 [Task] Investigate quantification of quantity precision (+/- 1 or +/- 0.5)
		Open		None	T77977 [Epic] Unit support
		Resolved		• Jonas	T98172 [Story] Implement Unit Selector widget
		Resolved		None	T110183 [Task] Plaintext formatter should render unit
		Resolved		Lydia_Pintscher	T142086 [Task] announce quantity changes
		Resolved		Ladsgroup	T142087 [Task] prepare bot for quantity change fixes
		Open		None	T112247 [RFC] Create a "number" datatype for exact values
		Resolved		Ladsgroup	T154168 Quantity changes broke ORES

Event Timeline

• Jonas created this task.Aug 25 2015, 2:26 PM

• Jonas raised the priority of this task from to Medium.

• Jonas updated the task description. (Show Details)

• Jonas added projects: Wikidata, Wikidata-Sprint-2015-08-18.

• Jonas subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2015, 2:26 PM

• Jonas set Security to None.Aug 25 2015, 2:26 PM

daniel mentioned this in rEWBAc5784d7cfbb4: Fix html escpaing for quantity formatter..Aug 26 2015, 8:52 AM

Diffusion mentioned this in rMEXT0df9ba098773: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 26 2015, 8:52 AM

• Jonas updated the task description. (Show Details)Aug 26 2015, 9:14 AM

• Jonas added subscribers: thiemowmde, daniel.

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Aug 26 2015, 10:50 AM

Change 233984 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Revert plain text QuantityFormatter to output unit by default

https://gerrit.wikimedia.org/r/233984

gerritbot added a project: Patch-For-Review.Aug 26 2015, 3:00 PM

Patches for review:

https://gerrit.wikimedia.org/r/233984
https://github.com/wmde/ValueView/pull/183 (merged)
https://github.com/wmde/ValueView/pull/186
ValueView needs a version bump and a release then.
The new version of ValueView must be used in Wikibase.git. This is done in https://gerrit.wikimedia.org/r/#/c/233948/.

thiemowmde mentioned this in T98172: [Story] Implement Unit Selector widget.Aug 26 2015, 3:38 PM

thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-18 board.Aug 26 2015, 3:40 PM

• Jonas added a parent task: T98172: [Story] Implement Unit Selector widget.Aug 27 2015, 9:08 AM

• Jonas closed this task as Resolved.Aug 27 2015, 2:53 PM

• Jonas moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.

Change 233984 merged by jenkins-bot:
Revert plain text QuantityFormatter to output unit by default

https://gerrit.wikimedia.org/r/233984

thiemowmde mentioned this in rEWBA356c8511b087: Revert plain text QuantityFormatter to output unit by default.Aug 27 2015, 3:56 PM

Diffusion mentioned this in rMEXT5cbea67b8f7a: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 27 2015, 3:56 PM

thiemowmde mentioned this in T95425: [Bug] Quantity formatter rounding causes significant data loss.Sep 3 2015, 1:59 PM