Page MenuHomePhabricator
Create Task
Maniphest T110675

[Story] Editing units should show unit label instead of URIs right away.
Closed, ResolvedPublic
Actions

Description

[Add] When I add a value with unit it should not be possible to enter non-vocabulary-repo URIs via the UI. It is only possible to select an Item from the vocabulary repo that represents the unit (via the suggester or copy-pasting a valid concept URI).

[Edit] When I edit a value with a unit:

  • Vocabulary repo concept URIs : it should never show the URI instead the label always is shown.
  • Some URI: it should show the URI and it should allow me to edit the value, but it is only possible to change the URI by selecting an item. (old Data/imports/errors)

In essence this means it is only possible to enter non vocabulary repo concept URIs via the API, but there must be a configuration that allows to reject non concept URIs of the vocabulary lookup repository.

Keep in mind:
In the future it should be possible to configure a remote vocabulary lookup repository that has the same behavior as on Wikidata (selecting, label resolving)

Details

SubjectRepoBranchLines +/-
Introduce VocabularyUriFormatter and use QuantityHtmlFormattermediawiki/extensions/Wikibasemaster+230 -97
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT56318 Quantity datatype (tracking)
OpenNoneT77977 [Epic] Unit support
ResolvedthiemowmdeT110675 [Story] Editing units should show unit label instead of URIs right away.
ResolveddanielT111171 [Task] Restrict URIs for units, calendars, and globes
ResolvedthiemowmdeT111172 [Task] Provide JS with sufficient information to determine the human readable label given the vocabulary URI for a unit
· · ·

Event Timeline

• Jonas created this task.Aug 28 2015, 1:51 PM
• Jonas raised the priority of this task from to High.
• Jonas updated the task description. (Show Details)
• Jonas added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
• Jonas added subscribers: Lydia_Pintscher, thiemowmde.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2015, 1:51 PM
• Jonas updated the task description. (Show Details)Aug 28 2015, 1:56 PM
• Jonas set Security to None.
• Jonas updated the task description. (Show Details)Aug 28 2015, 2:00 PM
• Jonas updated the task description. (Show Details)Aug 28 2015, 2:04 PM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Aug 31 2015, 10:07 AM
thiemowmde updated the task description. (Show Details)Sep 1 2015, 1:14 PM
thiemowmde added a project: ValueView.
thiemowmde updated the task description. (Show Details)Sep 1 2015, 1:17 PM
thiemowmde added a comment.EditedSep 1 2015, 1:22 PM

Note that there are two unrelated (sub) tasks in this tasks description:

  1. The task itself is about blocking non-Wikidata URIs on Wikidata, when editing via the UI.
  2. Non-concept URIs should be blocked via the relevant validator, e.g. wikidata.org/wiki/Q1 should actively be blocked, even if external URIs are allowed. I created a ticket for that but can't find it, see T102840: Disallow wikidata.org URIs to non-Item pages in unit/globe/calendar values.
  3. Introducing the necessary remote-lookups that are needed before a "vocabularyLookupApiUrl" setting (see https://gerrit.wikimedia.org/r/#/c/233948/5/view/resources/wikibase/view/ViewFactory.js) can be introduced must be tracked in other tickets (probably a bigger Story, if not an Epic).
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-09-01.Sep 1 2015, 1:23 PM
Lydia_Pintscher added a comment.Sep 1 2015, 3:11 PM

I created T111058 to split out the part of blocking other URIs.

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Sep 2 2015, 8:40 AM
thiemowmde added a parent task: T56318: Quantity datatype (tracking).Sep 2 2015, 9:17 AM
• Jonas updated the task description. (Show Details)Sep 2 2015, 10:14 AM
daniel renamed this task from [Story] Editing units should hide Wikidata concept URIs to [Story] Editing units should show unit label instead of URIs right away..Sep 2 2015, 12:06 PM
• Jonas assigned this task to thiemowmde.Sep 2 2015, 3:25 PM
• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2015-09-01 board.
thiemowmde added a project: Patch-For-Review.EditedSep 2 2015, 4:18 PM

Patches for review:

And:

daniel subscribed.Sep 2 2015, 4:24 PM

@Lydia_Pintscher Didn't see the task you created, so I created T111171: [Task] Restrict URIs for units, calendars, and globes. Sorry for the confusion, I have tried to sort it out now.

gerritbot subscribed.Sep 2 2015, 5:27 PM

Change 235495 had a related patch set uploaded (by Daniel Kinzler):
Use QuantityHtmlFormatter

https://gerrit.wikimedia.org/r/235495

daniel moved this task from Doing to Review on the Wikidata-Sprint-2015-09-01 board.Sep 2 2015, 5:31 PM
daniel closed subtask T111171: [Task] Restrict URIs for units, calendars, and globes as Resolved.Sep 4 2015, 2:17 PM
• Jonas subscribed.Sep 9 2015, 2:09 PM

Patch on github that enables showing the label instead of the uri https://github.com/wmde/ValueView/pull/190

JanZerebecki moved this task from Review to Doing on the Wikidata-Sprint-2015-09-01 board.Sep 9 2015, 2:39 PM
gerritbot added a comment.Sep 9 2015, 5:03 PM

Change 235495 merged by jenkins-bot:
Introduce VocabularyUriFormatter and use QuantityHtmlFormatter

https://gerrit.wikimedia.org/r/235495

thiemowmde mentioned this in rMEXT8fc339165d15: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 9 2015, 5:03 PM
thiemowmde mentioned this in rEWBAd7e999b64f90: Introduce VocabularyUriFormatter and use QuantityHtmlFormatter.
• Jonas closed this task as Resolved.Sep 10 2015, 9:37 AM
• Jonas closed subtask T111172: [Task] Provide JS with sufficient information to determine the human readable label given the vocabulary URI for a unit as Resolved.
• Jonas moved this task from Doing to Done on the Wikidata-Sprint-2015-09-01 board.
Ricordisamoa subscribed.Sep 10 2015, 11:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL