Banners do not show up in mobile editor preview or new beta feature "wikitext editor"
Open, Stalled, HighPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Aug 30 2015, 5:01 PM

Description

This impacts several projects including: Wikivoyages, cawiki, euwiki

Not sure why... but it would be useful for editing there :)

To reproduce:
Install WikidataPageBanner and MobileFrontend extension
Create a page "Test page" with text "{{PAGEBANNER:Agra banner Taj Mahal.jpg|originx=right}}" in the Vector skin.
Click preview and you'll see the banner in the preview.

Mobile site issue

Navigate to the mobile site using the 'Mobile view' link at the bottom of the desktop page.
Click the edit icon in the mobile mode for the same page.
Click next in the overlay
In the preview the banner is not present.

Wikitext editor issue

Enable the new wikitext editor feature
Click "Erakutsi aurreikuspena"
In the preview the banner is not present

Expected:
The banner should be rendering in the mobile editor and wikitext editor preview.

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T110843 Banners do not show up in mobile editor preview or new beta feature "wikitext editor"
Declined	None	T114424 API: Banner information
Resolved	Jdlrobson	T118937 Set relevant banner properties as an OutputPage property for api requests

Event Timeline

Jdlrobson created this task.Aug 30 2015, 5:01 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Wikidata-Page-Banner.

Jdlrobson moved this task to Backlog on the Wikidata-Page-Banner board.

Jdlrobson subscribed.

Restricted Application added a project: Wikidata. · View Herald TranscriptAug 30 2015, 5:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson moved this task from Backlog to Epics on the Wikidata-Page-Banner board.Aug 30 2015, 5:01 PM

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Aug 31 2015, 10:06 AM

Jdlrobson triaged this task as High priority.Sep 4 2015, 12:32 AM

Jdlrobson edited projects, added MobileFrontend, good first task; removed Wikidata.

Jdlrobson set Security to None.

Hey, I'm new to Mediawiki and was hoping to try solving this task as it is marked "Easy"

@Jdlrobson Could you give more information on this ? What is the "mobile editor preview" ?
I'm not very familiar with the terminology. A little more detail on steps to reproduce this would help.

Hi @TasneemLo thanks for the input! I've updated the description. Let me know if anything is still not clear! :)

Given that mobile editor uses api to fetch the wikitext and preview it, WikidataPageBanner would first need to handle 'action=parse' and return the banner HTML. See T107941

Sumit removed a project: good first task.Sep 25 2015, 5:13 AM

We'll need to add an API endpoint first!

Jdlrobson removed a project: MobileFrontend.Nov 4 2015, 5:03 PM

TasneemLo unsubscribed.Dec 20 2015, 9:12 AM

MBinder_WMF added a project: Web-Team-Backlog.May 17 2016, 6:33 PM

• Jhernandez added a project: Contributors-Team.May 25 2016, 4:18 PM

• Jhernandez moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.

Jdlrobson moved this task from Epics to Backlog on the Wikidata-Page-Banner board.Nov 14 2016, 12:16 PM

Blocked on T107941

Jdlrobson renamed this task from Banners do not show up in mobile editor preview to Banners do not show up in mobile editor preview or new beta feature "wikitext editor".Jul 27 2017, 7:28 PM

Jdlrobson added a project: VisualEditor.

Jdlrobson updated the task description. (Show Details)

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 27 2017, 7:28 PM

MBinder_WMF moved this task from 2014-15 Q4 to Tracking on the Web-Team-Backlog board.Oct 10 2017, 8:03 PM

MBinder_WMF edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 8 2021, 3:26 PM

LGoto removed a project: Web-Team-Backlog (Tracking).Nov 9 2021, 4:23 PM

Jdlrobson closed subtask T114424: API: Banner information as Declined.Dec 7 2021, 7:30 PM

Rather than page properties, which are stored and indexed in a separate database table, probably ParserOutput::setExtensionData() would be sufficient for this use case.

Banners do not show up in mobile editor preview or new beta feature "wikitext editor"Open, Stalled, HighPublicActions