Page MenuHomePhabricator

Spike: Design review of quick surveys and max-width work
Closed, ResolvedPublic

Description

Schedule some time with @KHammerstein and show her the quick surveys and max width in current form. Document bugs.
Create new sample articles as new issues are identified and required.

Output: task detailing what needs to be fixed up.
Duration: 1hr

Event Timeline

Jdlrobson assigned this task to Jhernandez.
Jdlrobson removed Jhernandez as the assignee of this task.
Jdlrobson raised the priority of this task from to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from Design review of quick surveys to Spike: Design review of quick surveys.Sep 2 2015, 4:35 PM
Jdlrobson set Security to None.
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-55-π board.
Jdlrobson raised the priority of this task from Medium to High.Sep 8 2015, 3:10 PM

@KHammerstein is at XOXO this week if I recall correctly so we should look to set this up asap.

So no @KHammerstein which means no design input since none of the designers are familiar with the work. She's back on Monday but this is when the next branch is cut

Several options:

  1. I use another designer as a proxy to check there is no red flags and with that sign off go ahead.
  2. We get sign off Monday morning from Kaity to get the go ahead to push on to the train.
  3. We merge now and use the remainder of the week to identify issues ourselves. We also check with kaity on Monday. SWATing between the Monday and Thursday that follows if necessary.
  4. We move the cards to next sprint and aim for Sept 14th release instead.

Personally I'm leaning towards 2 and 3 given the changes have been in beta for so long and I suspect an hour sign off is all that is needed.
Team (including @JKatzWMF) what do you think?

@Jdlrobson sounds good and it might be worth pinging kaity and seeing if
she is open to spending a couple of minutes doing it during her vacation.
if she's with family we could be doing her a favor ;)

Jdlrobson renamed this task from Spike: Design review of quick surveys to Spike: Design review of quick surveys and max-width work.Sep 9 2015, 8:03 PM
Jdlrobson updated the task description. (Show Details)

@atgo sorry looks like I messed up inviting you to meeting. Not sure what happened yet. I flagged positioning issues with @khammrstein but I think we should address those next sprint in T110362
Notes from meeting with @KHammerstein (will raise tasks)

Mobile:
quick survey shouldn't appear under last modified
quick survey left aligned (to match toc)

General:
heart should be customisable (remove until that's the case)

Desktop:
width=300px on desktop no max-width
quick survey should appear under infobox when present

Jdlrobson moved this task from Doing to Done on the Reading-Web-Sprint-55-π board.

Bugs created and sub tasks made under https://phabricator.wikimedia.org/T112203

@Jdlrobson Thanks for walking through all these with me!
@atgo Lets talk tomorrow :)