Page MenuHomePhabricator
Create Task
Maniphest T111233

We are loading JavaScript for blacklisted browsers
Closed, ResolvedPublic
Actions

Description

Either spoof your user agent with "Mozilla/4.0 (compatible; MSIE 6.1; Windows XP; .NET CLR 1.1.4322; .NET CLR 2.0.50727)" or use browser stack IE6.

Expected: No JavaScript expected to run on mobile or desktop
Actual: Mobile loads JS, desktop thows JavaScript errors after attempting to load

Traced back to T39894 (https://gerrit.wikimedia.org/r/#/c/234678/)
Setting to unbreak now as this is breaking browser tests for MobileFrontend and stopping us from merging.

Details

SubjectRepoBranchLines +/-
resourceloader: Ensure startup module returns early for incompatible browsersmediawiki/coremaster+1 -0
resourceloader: Ensure startup module returns early for incompatible browsersmediawiki/corewmf/1.26wmf21+1 -0
Revert "resourceloader: Remove global startUp() callback"mediawiki/coremaster+45 -42
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 2 2015, 6:42 PM
Jdlrobson raised the priority of this task from to Unbreak Now!.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: MediaWiki-ResourceLoader, Performance Issue, Reading-Web-Sprint-55-π.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 6:42 PM
gerritbot subscribed.Sep 2 2015, 6:44 PM

Change 235529 had a related patch set uploaded (by Jdlrobson):
Revert "resourceloader: Remove global startUp() callback"

https://gerrit.wikimedia.org/r/235529

gerritbot added a project: Patch-For-Review.Sep 2 2015, 6:44 PM
Jdlrobson added a parent task: T111087: MobileFrontend patches will not merge due to browser test failure.Sep 2 2015, 6:49 PM
gerritbot added a comment.Sep 2 2015, 7:25 PM

Change 235529 abandoned by Krinkle:
Revert "resourceloader: Remove global startUp() callback"

Reason:
Obsolete with Ie65427caee4231b4ca97a43.

https://gerrit.wikimedia.org/r/235529

gerritbot added a comment.Sep 2 2015, 7:25 PM

Change 235535 had a related patch set uploaded (by Krinkle):
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235535

Krinkle claimed this task.Sep 2 2015, 7:29 PM
Krinkle set Security to None.
gerritbot added a comment.Sep 2 2015, 7:30 PM

Change 235544 had a related patch set uploaded (by Krinkle):
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235544

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-55-π board.Sep 2 2015, 7:38 PM
gerritbot added a comment.Sep 2 2015, 7:39 PM

Change 235535 merged by jenkins-bot:
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235535

Krinkle mentioned this in rMW58a4a6649ec2: resourceloader: Ensure startup module returns early for incompatible browsers.Sep 2 2015, 7:39 PM
Krinkle removed a project: Performance Issue.Sep 2 2015, 7:44 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-55-π board.Sep 2 2015, 7:44 PM
gerritbot added a comment.Sep 2 2015, 7:47 PM

Change 235544 merged by jenkins-bot:
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235544

Krinkle mentioned this in rMW6c8aa791376a: resourceloader: Ensure startup module returns early for incompatible browsers.Sep 2 2015, 7:48 PM
• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-01_(1.26wmf21).Sep 2 2015, 8:00 PM
Krinkle closed this task as Resolved.Sep 2 2015, 8:07 PM
phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-55-π board.Sep 3 2015, 10:29 AM
Krinkle edited projects, added Performance-Team; removed Patch-For-Review.Aug 18 2016, 8:13 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 18 2016, 8:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL