QuickSurvey desktop tweaks
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 11 2015, 10:16 PM

Description

should be 300px width at all times
quick survey should appear above the infobox when present (similar to thumbnail)
~~The quick survey should also be left aligned in the Minerva skin. On the desktop skin it should be right aligned.~~ According to the new requirement the survey should always be left aligned on Desktop and Tablet, but full screen on mobile.

Details

	Subject	Repo	Branch	Lines +/-
	QuickSurvey tweaks	mediawiki/extensions/QuickSurveys	dev	+39 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T96785 In-channel feedback with star rating / picklist (and on apps, simple text entry?) and backend de-spam
Resolved	• Jhernandez	T104439 [GOAL]: Develop a mechanism for quick surveys on desktop + mobile
Resolved	Jdlrobson	T112203 Release version 0.2.0 of QuickSurveys.
Resolved	• bmansurov	T112343 QuickSurvey desktop tweaks

Event Timeline

Jdlrobson created this task.Sep 11 2015, 10:16 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Reading-Web-Sprint-56-Four Lions.

Jdlrobson added subscribers: Aklapper, Jdlrobson.

• KLans_WMF set Security to None.Sep 14 2015, 4:28 PM

• KLans_WMF edited a custom field.

• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-56-Four Lions board.

Jdlrobson updated the task description. (Show Details)Sep 14 2015, 4:30 PM

• bmansurov claimed this task.Sep 16 2015, 1:18 AM

• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-56-Four Lions board.

Change 238667 had a related patch set uploaded (by Bmansurov):
QuickSurvey tweaks

https://gerrit.wikimedia.org/r/238667

gerritbot added a project: Patch-For-Review.Sep 16 2015, 2:36 AM

• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 16 2015, 2:37 AM

Seemed to cause a regression in mobile on the sample article - http://imgur.com/y5z7KlO
http://localhost:8888/w/index.php/Quick_survey_test_page_with_infobox_with_image?quicksurvey=true&useformat=mobile

The regression has been fixed. But it still looks weird because of the requirements. According to the requirements on mobile the survey should be left aligned even tough the infobox is right aligned.

• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 17 2015, 12:21 AM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-56-Four Lions board.Sep 17 2015, 6:56 PM

At this stage I'm not sure what the problem is. In the patch panel is left aligned in Minerva according to the task requirement, but the patch still got a -1 because it should be right aligned? Please someone clarify what I should do. Thanks.

• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 18 2015, 1:02 AM

• bmansurov updated the task description. (Show Details)Sep 18 2015, 1:07 AM

I discussed this earlier with @KHammerstein. In Vector skin and minerva skin (tablets) it should be right aligned. In minerva (mobile) it should be full width. Apologies the card was ill-thought out.

Change 238667 merged by jenkins-bot:
QuickSurvey tweaks

https://gerrit.wikimedia.org/r/238667