Page MenuHomePhabricator
Create Task
Maniphest T1126

Mobile friendly OAuth permission screen when logging in to Phabricator
Closed, ResolvedPublic
Actions

Description

Originally reported by @Jaredzimmerman-WMF in Bug 73062:

when OAuth is triggered on mobile browsers, it still overlays the desktop site, and the dialog is not formatted for mobile screen.

IMG_0448.PNG (1×750 px, 92 KB)

@csteipp 2014-11-06 00:42:49 UTC
The app owner can fix this by setting the redirect url to a clean mediawiki url (www.mediawiki.org/wiki/Special:OAuth/authorize?whatever), instead of a /w/index.php?title=Special:OAuth/authorize&whatever url.

This is because mobile frontend's varnish config doesn't attempt to detect mobile devices for non-clean urls.
Status: NEW → RESOLVED
Resolution: --- → INVALID

Therefore, it looks like the fix needs to be done in the Phabricator side.

Related Objects

Event Timeline

Qgil created this task.Nov 6 2014, 12:23 PM
Qgil raised the priority of this task from to Medium.
Qgil updated the task description. (Show Details)
Qgil added a project: Phabricator.
Qgil changed Security from none to None.
Qgil added subscribers: • Jaredzimmerman-WMF, • csteipp.
Qgil subscribed.
Qgil added a subscriber: • mmodell.Nov 27 2014, 7:59 AM
Qgil added a comment.EditedDec 8 2014, 7:41 AM

Is this an easy task? I'm asking to add the "Easy" tag or not.

• Jaredzimmerman-WMF added a comment.Dec 8 2014, 7:31 PM

@Qgil probably? I honestly don't know, perhaps Chris S. would want to weigh in.

• csteipp added a comment.Dec 8 2014, 11:25 PM
In T1126#831225, @Jaredzimmerman-WMF wrote:

@Qgil probably? I honestly don't know, perhaps Chris S. would want to weigh in.

It depends on what is desired here. If it's a single app that can update the url they're sending the users to, that's easy. If we want to MobileFrontend to handle this for everyone, that's a more difficult change.

Qgil added a comment.Dec 9 2014, 2:09 PM

I'm just talking about the MediaWiki login button at https://phabricator.wikimedia.org/auth/start/ linking to a mobile friendly Oauth dialog when a mobile device is detected.

Qgil moved this task from To Triage to Need discussion on the Phabricator board.Dec 9 2014, 2:10 PM
• mmodell mentioned this in T75062: OAuth permission screen needs redesign for better usability and comprehension.Jan 6 2015, 4:09 PM
Aklapper lowered the priority of this task from Medium to Lowest.Jan 21 2015, 1:42 AM
Aklapper subscribed.

As most users will likely remain logged in on their mobile phones this seems to be an inconvenience that's not exposed very often (and I also hope that most mobile browsers allow zooming in nowadays). Hence lowering priority.

Aklapper moved this task from Need discussion to Misc on the Phabricator board.Oct 7 2016, 4:44 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 7 2016, 4:44 PM
• IZoid added a subtask: T49578: Score should output SVG.Dec 9 2017, 6:34 PM
Ebe123 removed a subtask: T49578: Score should output SVG.Dec 9 2017, 6:37 PM
Aklapper renamed this task from Mobile friendly OAuth permission screen when registering to Phabricator to Mobile friendly OAuth permission screen when logging in to Phabricator.Jul 27 2018, 7:33 PM
Aklapper closed this task as Resolved.Jul 27 2018, 7:35 PM
Aklapper added a project: Mobile.

Cannot reproduce:

Снимок_Экрана_20180727_001.png (960×540 px, 93 KB)

If you can still reproduce, please reopen and provide better environment information to reproduce (screen size, etc).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL