[Story] Add Wikibase support for PageImages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Sep 17 2015, 10:17 AM

Description

This would allow an image to appear in places like mobile search results and Special:Nearby.

Task: Create a ordered list of desired properties for an page image
Task: Choose the top ranked image from main statements of an item and put it to page props using visitor pattern from https://gerrit.wikimedia.org/r/#/c/243613/4

Details

Subject	Repo	Branch	Lines +/-
Rework standalone PageImagesDataUpdate into a ParserOutputDataUpdate	mediawiki/extensions/Wikibase	master	+78 -48
Introduce PageImagesDataUpdate for PageImages extension	mediawiki/extensions/Wikibase	master	+352 -0
Add GeoData and PageImages configuration for Wikibase repo wikis	operations/mediawiki-config	master	+59 -1
Add basic PHPUnit tests	mediawiki/extensions/PageImages	master	+121 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T78430 [Epic] Getting Wikidata to render nicely on mobile web
Resolved	None	T110033 [Story] Redirect users on mobile devices to mobile site automatically
Resolved	Bene	T85368 [Story] Search for Wikidata should give meaningful results on mobile as well
Open	None	T96040 Wikibase special pages (tracking)
Resolved	aude	T159678 [Bug] Special:Nearby isn't showing thumbnails on Wikidata
Resolved	aude	T112531 [Story] see items around me (Special:Nearby)
Resolved	None	T116889 [Bug] page_image entry (with empty value) added to page_props for entities with no relevant page image
Resolved	thiemowmde	T112865 [Story] Add Wikibase support for PageImages

Event Timeline

aude created this task.Sep 17 2015, 10:17 AM

aude raised the priority of this task from to Medium.

aude updated the task description. (Show Details)

aude added projects: Wikidata, PageImages.

aude subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 10:17 AM

aude set Security to None.Sep 17 2015, 10:17 AM

aude added a parent task: T112531: [Story] see items around me (Special:Nearby).

aude added a subscriber: Bene.

aude renamed this task from Add Wikibase support for PageImages to [Task] Add Wikibase support for PageImages.Sep 17 2015, 11:56 AM

Bene added a parent task: T85368: [Story] Search for Wikidata should give meaningful results on mobile as well.Sep 17 2015, 12:15 PM

Bene awarded a token.Sep 17 2015, 12:20 PM

JanZerebecki moved this task from incoming to needs discussion or investigation on the Wikidata board.Sep 18 2015, 12:42 PM

• Jonas renamed this task from [Task] Add Wikibase support for PageImages to [Story] Add Wikibase support for PageImages.Sep 25 2015, 1:54 PM

JanZerebecki added a project: Story.Sep 25 2015, 8:27 PM

aude added a project: Wikidata-Sprint-2015-09-29.Sep 30 2015, 9:37 AM

Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2015-09-29 board.Sep 30 2015, 10:05 AM

Decisions made with @Lydia_Pintscher:

No audio and video.
No images of graves, epitaphs and commemorative plaques.
Any image is better than no image, therefore we are adding maps and diagrams, even if they are unreadable in thumbnail sizes.

Order is roughly from complex to simple and from specific to generic:

Photos
1. image (P18)
Complex graphics
Simple graphics
Multipage content
1. scan file (Commons) (P996)
Maps
Diagrams

These properties should be stored in a config variable in that order I supppose?

Obviously, yes, very similar to wgPropertySuggesterClassifyingPropertyIds being an array of property ids (but I will obviously avoid numeric ids).

Change 243673 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[WIP] Introduce PageImagesHookHandler for PageImages extension

https://gerrit.wikimedia.org/r/243673

gerritbot added a project: Patch-For-Review.Oct 5 2015, 3:23 PM

All the extension does (besides the "pageimages" API module) is appending a page property called "page_image" for each page id to the page_props table, containing the pure file name without the namespace. (And it does that in a way that's not really applicable for our code base, by accessing LinksUpdate::$mProperties.) That's all. That's so simple, the only reason to bind to the PageImages extension is literally the constant PageImages::PROP_NAME with the "page_image" string. As far as I can see, not even major refactoring of the PageImages class would make it possible to reuse existing code.

I suggest to not bind against the PageImages extension but simply ... well, rely on class_exists( 'PageImages' )?

To do:

What about the wgPageImagesNamespaces setting? Problem is, the PageImages extension should not work on Wikibase namespaces. But at the same time it would be confusing to have two separate settings for the same thing.
What about the wgPageImagesBlacklist? Our code should respect this.

Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.Oct 6 2015, 3:24 PM

• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2015-09-29 board.Oct 7 2015, 9:35 AM

• Jonas assigned this task to thiemowmde.Oct 7 2015, 9:37 AM

• Jonas updated the task description. (Show Details)Oct 7 2015, 10:11 AM

Change 244165 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add pageImagesPropertyIds configuration for Wikibase servers

https://gerrit.wikimedia.org/r/244165

Change 244175 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add basic PHPUnit tests

https://gerrit.wikimedia.org/r/244175

Change 243673 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Introduce PageImagesDataUpdate for PageImages extension

https://gerrit.wikimedia.org/r/243673

Change 244175 merged by jenkins-bot:
Add basic PHPUnit tests

https://gerrit.wikimedia.org/r/244175

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 8 2015, 9:00 AM

thiemowmde moved this task from Doing to Review on the Wikidata-Sprint-2015-09-29 board.Oct 8 2015, 10:28 AM

@Lydia_Pintscher's (product manager) decision: For now we will not support the wgPageImagesBlacklist setting. We will most probably never need it for our algorithm, which is not based on parsing wikitext but on ranked statements.
We are introducing a new Wikibase specific pageImagesPropertyIds setting in https://gerrit.wikimedia.org/r/243673 and https://gerrit.wikimedia.org/r/244165.
We do not need an additional boolean setting. Instead, pageImagesPropertyIds is empty by default. To enable the feature, add a list of image property ids.
We do not need to support the wgPageImagesNamespaces setting. Instead, when pageImagesPropertyIds is set the feature is enabled on all entity namespaces that support statements.