| Esanders | |
| Sep 25 2015, 2:56 PM |
| F15864025: image.png | |
| Mar 19 2018, 5:00 AM |
| F15864023: image.png | |
| Mar 19 2018, 5:00 AM |
| F2644101: wDAZY9W.png | |
| Sep 29 2015, 1:49 AM |
| F2644099: A99nppw.png | |
| Sep 29 2015, 1:49 AM |
| F2634610: pasted_file | |
| Sep 25 2015, 2:56 PM |
| F2634613: pasted_file | |
| Sep 25 2015, 2:56 PM |
Compare:
There are other cases where we use dropdowns attached to focused inputs, and we never outline them.
Some pages currently using DateInputWidget:
Resolving patch output:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove blue border from DateInputWidget calendar | mediawiki/core | master | +17 -18 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T113560 Standardize MediaWiki components (tracking) | |||
| Resolved | matmarex | T113741 DateInputWidget: popup CalendarWidget shouldn't have a blue border |
Change 241082 had a related patch set uploaded (by Esanders):
Remove blue border from DateInputWidget calendar
The text field itself continues to have the blue focus border, just not the calendar. (When a calendar is focussed by itself, it should also have the border, but not otherwise.)
We discussed this with @Esanders on IRC and we agreed on using the following for now (the patch is updated):
| When focus is on the text field |  |
| When focus is on the calendar |  |
Long-term, we'd like to have different calendar-specific focus styles (right now we're just reusing the one used for textual inputs, which is confusing), and we'd like the text input field to keep looking focussed while the focus is on the calendar (we need to think up a non-hacky implementation).
Change 241082 merged by jenkins-bot:
Remove blue border from DateInputWidget calendar
Yes, the blue border is used to indicate a focused text input only, so while Bartosz's patch is an improvement it does not close this bug.
@matmarex No idea. :)
Looks good and is coherent for an interactive element. We could further discuss if the calendar needs focus outline, but when we were to decide it does not, we would need to have tab functionality with better user feedback clarified. I prefer living with this (good) compromise before spending extra time here.