Page MenuHomePhabricator

Two cite errors get empty error messages.
Closed, InvalidPublic

Description

Hello.
The code

<ref group=uoh>jgjhgj</ref>

(without reference template)
throws an error

Cite error:

with empty $1, when should use "Mediawiki: Cite error group refs without references". Even this example does not work.
Thank you.
N3: The same problem happens with "Mediawiki:Cite error references invalid parameters group". All the rest work well.

Event Timeline

IKhitron raised the priority of this task from to Needs Triage.
IKhitron updated the task description. (Show Details)
IKhitron added a project: Cite.
IKhitron added subscribers: IKhitron, Kipod, eranroz and 2 others.
IKhitron renamed this task from Undefined group in ref without references template gets empty error message. to Two cite errors get empty error messages..Oct 23 2015, 7:43 PM
IKhitron updated the task description. (Show Details)
IKhitron set Security to None.

I checked them all and found another one.

I think it is urgent for you to know this. After 5 days without answer it seems like noone saw this. If "Cite" project programmer thinks it is not urgent - he can always change this. And why do I think it is urgent for you to know this - because I'm sure that the last two patchs for duplicated ref erased something important in the code.

I can't reproduce either of these issues.

Hmm, yeah, I can reproduce on the Hebrew Wikipedia, but not anywhere else. I'm pretty sure it has something to do with the override of MediaWiki:Cite error, but I'm having trouble following that code well enough to debug it. It looks like you're doing some text replacements to undo the effects of T115809, but it goes several templates deep and it's all in Hebrew which I don't speak :)

Oooh, I have a thought. The 'cite_error_group_refs_without_references' message contains a few '=' characters, and after it replaces the $1 in {{פענוח/הערות|$1}}, it might be treated as parameter name and value, rather than value for the unnamed parameter 1. Try {{פענוח/הערות|1=$1}} and see if that fixes it?

@matmarex, you are genius, and I am stupid.
By the way, for me, this code does not create any message in enwiki, an this is not good.

By the way, for me, this code does not create any message in enwiki, an this is not good.

They wrap all their errors in the {{broken ref}} template which apparently contains some magic that makes it not display in user sandboxes for some reason. The error appears correctly in articles.

matmarex claimed this task.

Happy to have helped :)

I see. Thank you very much for all your help.