Maniphest T121343

SingleEditTab: Exception thrown switching from VE to WE while logged out
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Dec 13 2015, 2:56 PM

Tags

Referenced Files

None

Subscribers

Description

TypeError: Cannot read property 'setEditorPreference' of undefined at ve.init.mw.DesktopArticleTarget.js:1375:17

Details

	Subject	Repo	Branch	Lines +/-
	Fix setEditorPreference call	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T52000 Enable VisualEditor by default for all users of all Wikimedia wikis
		Open		None	T51999 Enable VisualEditor by default for all users of all Wikipedias
		Open		None	T90662 Re-enable VisualEditor by default for all users of the English Wikipedia
		Open		None	T90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
		Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
		Resolved		Krenair	T55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
		Resolved		• AlexMonk-WMF	T55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
		Open		None	T114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
		Resolved		Krenair	T89060 VisualEditor is not the editor linked from the diff page
		Open		None	T78550 The undo link in the page history leads to the source editor and not VisualEditor
		Open		None	T185548 Undo notification is not sent if the editor switches to the visual editor
		Open		None	T54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
		Open		None	T102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
		Resolved		Krenair	T54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
		Resolved		Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
		Resolved		Krenair	T121343 SingleEditTab: Exception thrown switching from VE to WE while logged out

Event Timeline

Esanders created this task.Dec 13 2015, 2:56 PM

Esanders raised the priority of this task from to Unbreak Now!.

Esanders updated the task description. (Show Details)

Esanders added projects: VisualEditor, VisualEditor-MediaWiki.

Esanders added subscribers: Esanders, Krenair.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2015, 2:56 PM

Krenair claimed this task.Dec 14 2015, 4:48 PM

Change 259007 had a related patch set uploaded (by Alex Monk):
Fix setEditorPreference call

https://gerrit.wikimedia.org/r/259007

gerritbot added a project: Patch-For-Review.Dec 14 2015, 4:49 PM

Change 259007 merged by jenkins-bot:
Fix setEditorPreference call

https://gerrit.wikimedia.org/r/259007

Jdforrester-WMF closed this task as Resolved.Dec 14 2015, 5:09 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Krenair added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.Dec 14 2015, 5:35 PM

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 14 2015, 6:00 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jan 13 2016, 4:33 PM