Page MenuHomePhabricator

[Bug] ValueView GitHub mirror not updated any more
Closed, ResolvedPublic

Description

The Gerrit repository created in T112120: [Task] Move ValueView repository from github to gerrit is mirrored to the Wikimedia-GitHub at https://github.com/wikimedia/data-values-value-view. But when you look at https://github.com/wikimedia/data-values-value-view/commits/master it stops 7 days ago. Later commits and tags are missing.

This blocks further development because Composer depends on Packagist, and Packagist depends on Github.

Event Timeline

thiemowmde raised the priority of this task from to Unbreak Now!.
thiemowmde updated the task description. (Show Details)

I asked ops why and its unclear. Could try manual sync via a local git clone with both remotes.

gerrit show-queue --wide shows this:

Task     State        StartTime         Command
------------------------------------------------------------------------------
50fce8d1 23:28:14.187 23:27:14.187      (retry 10121) push git@github.com:wikimedia/IPSet
d08a1875 23:28:34.664 23:27:34.665      (retry 9123) push git@github.com:wikimedia/data-values-value-view
b8014a14 19:00:29.246 Dec-11 18:00      Log File Compressor
------------------------------------------------------------------------------
  3 tasks

I didn't see anything extra on github (for reference, it was at https://github.com/wikimedia/data-values-value-view/commit/4c944f1ff3bd549fcb7e73b6c36d3168f363c2ef ) so I just pushed from a gerrit clone to github and it was fine... Someone try merging a commit in gerrit to test it?

JanZerebecki lowered the priority of this task from Unbreak Now! to Medium.Jan 13 2016, 11:36 PM
JanZerebecki set Security to None.
thiemowmde raised the priority of this task from Medium to Unbreak Now!.Jan 15 2016, 11:37 AM

Latest commits and new tags we created still do not show up on the GitHub mirror.

I'm waiting for ValueView 0.15.7 to be released for a month now, see https://gerrit.wikimedia.org/r/259760.

I tried to manually update the mirror but can't because I do not have any rights there.

I tried (again) to teach Packagist to use the correct repository, which in my opinion is https://gerrit.wikimedia.org/r/data-values/value-view. Packagist seems to recognize this and finally shows the new tag 0.15.7. But when I try to run composer it fails with bogus error messages.

[RuntimeException]
Failed to execute git remote set-url composer 'https://gerrit.wikimedia.org/r/data-values/value-view' && git fetch composer && git fetch --tags composer
fatal: No such remote 'composer'

This is seriously blocking us. What else could we do?

Replication is complaining about a missing object 3e588b1f9e4b7e39bf38e43e9b21ccf9f2cb2c94. I cannot find this object on Github or on Gerrit.

Fixed? I killed the replication job and issued a new one. If I had to guess I'd say it was a PR branch open when the job began attempting, which has since been deleted after merging.

My local clone that still has the pre-gerrit-move github origin around does not know that object either.

I did:

$ git push github-mirror master
$ git push --tags github-mirror

And both caused updates on a remote branch. So the replication is still not working, but the new tag is now on github.

JanZerebecki lowered the priority of this task from Unbreak Now! to High.Jan 15 2016, 10:23 PM

Using the new tag in https://gerrit.wikimedia.org/r/259760 is now working.

I tried to manually update the mirror but can't because I do not have any rights there.

I invited you to https://github.com/orgs/wikimedia/teams/wikidata which gives you the permissions.

I tried (again) to teach Packagist to use the correct repository, which in my opinion is https://gerrit.wikimedia.org/r/data-values/value-view. Packagist seems to recognize this and finally shows the new tag 0.15.7. But when I try to run composer it fails with bogus error messages.

[RuntimeException]
Failed to execute git remote set-url composer 'https://gerrit.wikimedia.org/r/data-values/value-view' && git fetch composer && git fetch --tags composer
fatal: No such remote 'composer'

Did you remove vendor before this?

Replication is complaining about a missing object 3e588b1f9e4b7e39bf38e43e9b21ccf9f2cb2c94. I cannot find this object on Github or on Gerrit.

Here it is: https://github.com/wikimedia/data-values-value-view/commit/3e588b1f9e4b7e39bf38e43e9b21ccf9f2cb2c94

It seems this repo was before moved from gerrit to github. During the migration to gerrit I left refs/meta/config on the github repo untouched (didn't know about its existence) when I moved it over the gerrit created github mirror. I deleted that ref with git push github-mirror :refs/meta/config, so maybe replication works now, after it is restarted?

I just checked with git ls-remote and the github mirror still does not have refs/meta/config, which means syncing is still not working. Please restart the replication task? Does it still complain?

This is a know issue. Something to do with moving/trying replication from phabricator.

And this problem affects git.wikimedia.org and GitHub mirrors but phabricator is unaffected.

This is a know issue. Something to do with moving/trying replication from phabricator.

No, that's unrelated.

I just checked with git ls-remote and the github mirror still does not have refs/meta/config, which means syncing is still not working. Please restart the replication task? Does it still complain?

I've run it several times. I see no job for kicking off to Github. I do see eg:

098ec629 21:41:30.888 21:41:15.889      push gerritslave@antimony.wikimedia.org:/var/lib/git/data-values/value-view.git

Gerrit's error log is suspiciously silent.

Oh. Seems that some repos are updating on GitHub but mediawiki core isent.

Hi I believe that the mirrors were fixed, I think they were trying something out like doing the replication from phabricator to GitHub but that stopped since it wasn't working.

JanZerebecki claimed this task.

refs/meta/config is still not mirrored, but it is probably not necessary. master is mirrored fine.

refs/meta/config is still not mirrored, but it is probably not necessary. master is mirrored fine.

We don't mirror refs/changes/* or refs/meta/* to Github usually, it should just be refs/heads/* and refs/tags/*