Maniphest T125688

Gather should not use MobileFrontend Skin class
Closed, ResolvedPublic
Actions

Description

This causes issues, primarily the possible double loading of the skin class and should be cleaned up straight away.
This work is blocking the lazy loading of images work.

Details

	Subject	Repo	Branch	Lines +/-
	PointerOverlays can now work without Skin object	mediawiki/extensions/MobileFrontend	master	+6 -9
	Hygiene: Do not create Skin's in Gather	mediawiki/extensions/Gather	master	+4 -48

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
		Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
		Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
		Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
		Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
		Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
		Resolved		dr0ptp4kt	T114542 Next Generation Content Loading and Routing, in Practice
		Duplicate		• Jhernandez	T104432 [EPIC]: Improve mobile site performance
		Duplicate		dr0ptp4kt	T120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
		Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
		Resolved		Jdlrobson	T113066 [GOAL] Make Wikipedia more accessible to 2G connections
		Resolved		Jdlrobson	T124390 [GOAL] Load images with care
		Resolved		• Jhernandez	T124770 Feature flagged Lazily load images
		Resolved		• Jhernandez	T125688 Gather should not use MobileFrontend Skin class

Event Timeline

Jdlrobson created this task.Feb 3 2016, 6:45 PM

Jdlrobson claimed this task.

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Reading-Web-Sprint-65-Game of Phones, Gather.

Jdlrobson updated the task description. (Show Details)

Jdlrobson set Security to None.

Jdlrobson added subscribers: gerritbot, Krinkle, Jdlrobson and 9 others.

Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-65-Game of Phones board.Feb 3 2016, 7:06 PM

Many reason this exists is for the PointerOverlay... Urerfggh

Let me see if I can throw this dependency away.

this.options.skin.on( 'changed', $.proxy( this, 'refreshPointerArrow', this.options.target ) );

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-65-Game of Phones board.Feb 3 2016, 10:58 PM

Change 268312 had a related patch set uploaded (by Jdlrobson):
PointerOverlays can now work without Skin object

https://gerrit.wikimedia.org/r/268312

Change 268313 had a related patch set uploaded (by Jdlrobson):
Hygiene: Do not create Skin's in Gather

https://gerrit.wikimedia.org/r/268313

Change 268313 merged by jenkins-bot:
Hygiene: Do not create Skin's in Gather

https://gerrit.wikimedia.org/r/268313

Change 268312 merged by jenkins-bot:
PointerOverlays can now work without Skin object

https://gerrit.wikimedia.org/r/268312

phuedx removed Jdlrobson as the assignee of this task.Feb 4 2016, 11:52 AM

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-65-Game of Phones board.

phuedx triaged this task as Medium priority.Feb 4 2016, 6:14 PM

@Jhernandez can you please sign off since you reported the issue?

On it

Verified locally

Verified on Beta cluster as well.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).Feb 8 2016, 6:02 PM