In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Krenair
	Feb 5 2016, 4:29 PM

Description

You are left with a blank page and the URL is changed to look like you are reading the page...
I guess we should attempt to fall back to the wikitext editor somehow in this case?
I'm getting increasingly worried about all the different ways the "suppress wikitext editor if we expect VE to load over the top of it immediately" CustomEditor hack could break. :/

Details

	Subject	Repo	Branch	Lines +/-
	Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit	mediawiki/extensions/VisualEditor	master	+12 -10

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T52000 Enable VisualEditor by default for all users of all Wikimedia wikis
Open		None	T51999 Enable VisualEditor by default for all users of all Wikipedias
Open		None	T90662 Re-enable VisualEditor by default for all users of the English Wikipedia
Open		None	T90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Resolved		Krenair	T55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
Resolved		• AlexMonk-WMF	T55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
Open		None	T114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
Resolved		Krenair	T89060 VisualEditor is not the editor linked from the diff page
Open		None	T78550 The undo link in the page history leads to the source editor and not VisualEditor
Open		None	T185548 Undo notification is not sent if the editor switches to the visual editor
Open		None	T54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
Open		None	T102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
Resolved		Krenair	T54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
Resolved		Krenair	T58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
Resolved		Krenair	T125998 In single edit tab mode, when you load VE directly by browsing to action=edit, and it fails to load, bad things happen

Event Timeline

Krenair created this task.Feb 5 2016, 4:29 PM

Krenair raised the priority of this task from to Needs Triage.

Krenair updated the task description. (Show Details)

Krenair added projects: VisualEditor, VisualEditor-MediaWiki.

Krenair subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 5 2016, 4:29 PM

Krenair added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.Feb 5 2016, 4:31 PM

Jdforrester-WMF triaged this task as Medium priority.Feb 5 2016, 7:00 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Jdforrester-WMF set Security to None.

@Jdforrester-WMF: So what should be the proper behaviour in this case?

Fallback to an editor, any editor.

The problem is ensuring we don't try to fallback into VE itself and get into a loop.

Fallback to WT if VE fails to load seems better than falling back to read mode (and much better than an infinite look or a blank page, yes).

So, I think we can do this: When we detect failure to load on action=edit but there's no #wpTextbox1 on the page, change location to the current URL with &veswitched=1
This should avoid setting any cookies/preferences, and not interfere with WTE->VE switch failures.

Change 270440 had a related patch set uploaded (by Alex Monk):
Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit

https://gerrit.wikimedia.org/r/270440

gerritbot added a project: Patch-For-Review.Feb 12 2016, 11:39 PM

Krenair claimed this task.Feb 12 2016, 11:46 PM

Jdforrester-WMF closed this task as Resolved.Feb 16 2016, 4:46 PM

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)); removed Patch-For-Review.

Jdforrester-WMF edited a custom field.

Change 270440 merged by jenkins-bot:
Try to switch into the wikitext editor automatically if there is an error loading VE on action=edit

https://gerrit.wikimedia.org/r/270440