Page MenuHomePhabricator
Create Task
Maniphest T128926

Citation Bot not logged in when trying to do auto-expansion
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

See bug report at https://en.wikipedia.org/wiki/User_talk:Citation_bot#Bot_has_been_logged_out.

From the talk page:

Or it could be that the bot isn't properly handling cookies: it copies the Set-Cookie headers from the initial call to action=login (without correctly handling deleted cookies), then it manually constructs cookies from the deprecated response values which are likely to be failing to be valid anymore with the increased validation of the session data. Anomie⚔ 01:14, 20 February 2016 (UTC)

The bot should be updated to use proper log-in procedures.

Code lives at https://github.com/ms609/citation-bot.

Event Timeline

kaldari created this task.Mar 4 2016, 11:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2016, 11:48 PM
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Mar 4 2016, 11:48 PM
kaldari added a comment.Mar 6 2016, 9:50 PM

Bug can be reproduced by clicking "Expand citations" in the sidebar at https://en.wikipedia.org/wiki/Super_Star_Wars.

Ricordisamoa subscribed.Mar 7 2016, 1:35 PM
Closedmouth subscribed.Mar 8 2016, 1:36 PM
• DannyH added a parent task: T120435: Improve the plagiarism detection bot.Mar 11 2016, 6:13 PM
• Fhocutt updated the task description. (Show Details)Mar 11 2016, 6:17 PM
• DannyH assigned this task to • Fhocutt.Mar 11 2016, 6:19 PM
• DannyH triaged this task as High priority.
• DannyH set the point value for this task to 5.
• DannyH moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
eranroz removed a parent task: T120435: Improve the plagiarism detection bot.Mar 11 2016, 8:21 PM
• DannyH edited projects, added Community-Tech-Sprint; removed Community-Tech.Mar 12 2016, 12:22 AM
• DannyH moved this task from Ready to In Development on the Community-Tech-Sprint board.Mar 15 2016, 5:07 PM
• DannyH moved this task from In Development to Ready on the Community-Tech-Sprint board.Mar 22 2016, 5:10 PM
• DannyH added a project: Community-Tech.Mar 22 2016, 5:21 PM
• DannyH removed a project: Community-Tech-Sprint.
kaldari removed • Fhocutt as the assignee of this task.Mar 29 2016, 5:43 PM
kaldari added a subscriber: • Fhocutt.
kaldari moved this task from Up Next (June 3-21) to Design backlog on the Community-Tech board.Apr 7 2016, 5:00 PM
Josve05a awarded a token.Apr 10 2016, 6:18 PM
Josve05a subscribed.Apr 22 2016, 7:31 AM

Please... :/

Josve05a added a comment.EditedApr 29 2016, 1:59 PM

Could the tasks "Relogging the bot" and "update to use an appropriate PHP MediaWiki API client library"be split in to different tasks, so that the bot could be relogged and be used in the meantime...or isn't it that simple?

kaldari updated the task description. (Show Details)Apr 29 2016, 2:10 PM

@Josve05a: Changed as you suggested.

kaldari updated the task description. (Show Details)Apr 29 2016, 2:14 PM
kaldari added a comment.Apr 29 2016, 3:16 PM

Current login function lives at expandFns.php: logIn().

kaldari added a comment.Apr 30 2016, 8:44 PM

@Josve05a: Submitted a pull request: https://github.com/ms609/citation-bot/pull/106

Now we just have to hope that Martin is still around to merge and deploy it.

kaldari claimed this task.Apr 30 2016, 8:44 PM
kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.
kaldari moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Josve05a added a comment.May 5 2016, 5:15 PM
In T128926#2254056, @kaldari wrote:

@Josve05a: Submitted a pull request: https://github.com/ms609/citation-bot/pull/106

Now we just have to hope that Martin is still around to merge and deploy it.

He merged it. Any way we can get the bot operational again?

kaldari added a comment.May 12 2016, 7:22 PM

@Josve05a: He merged it, but hasn't actually updated the code on Tool Labs. I'll see if I can track down one of the project maintainers to run git pull.

kaldari closed this task as Resolved.May 13 2016, 2:48 PM

Fixed now and the gadget has been updated.

kaldari moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.May 13 2016, 2:48 PM
• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.May 24 2016, 8:17 PM
• DannyH moved this task from Design backlog to Archive on the Community-Tech board.May 24 2016, 8:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL