This is to implement a card for the feed that contains a "trending" reading suggestion.
This shall retrieve the trending articles from the corresponding MCS endpoint.
This is to implement a card for the feed that contains a "trending" reading suggestion.
This shall retrieve the trending articles from the corresponding MCS endpoint.
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Dbrant | T129076 Implement Feeds in the Android app. | |||
Resolved | • Niedzielski | T129082 [Feeds] Implement "trending article" card. | |||
Resolved | • Mholloway | T132766 [Feeds] Implement Content Service endpoint for "trending articles" |
Notes from services / reading sync-up meeting:
While this will initially be pageview data based, it is likely that other signals / filters will be added later. For that reason, it might make sense to keep this out of metrics / T119094.
Proposals for entry points:
Suggest we call this "pageviews" to match the analytics team's name for the API and because it doesn't actually track trends...
So far, looks like we have two votes for 'pageviews' (@JMinor and @Fjalapeno) as the endpoint path segment. I agree 'trending' probably isn't right but prefer something more like 'most-read' in order to better distinguish it from analytics' 'pageviews' work. Now's probably a good time for a final decision. Any other votes/ideas?
I haven't participated in these discussion much lately because I've been pleased with all the options I've seen and I don't have a strong or informed opinion about this. @Mholloway, thanks for the cc. All the options you mentioned sound reasonable.
Here's my limited perspective as a client. If the Content Service implementation is a transparent wrapper around the pageview API, then it seems like a no-brainer to call it pageview. If the Content Service alter things in any way, then I might find it a little surprising but at least it's mostly right. I _think_ we do the latter so I would slightly prefer something like popular, most-read, trending, etc, or maybe even something like pageviews/popular or pageviews/most-read to indicate something that's _like_ or uses pageviews but is also a little more refined than that. I'm also a big fan of the page/trending endpoint @GWicke mentioned and would pitch a few more in that vein as page/stat, page/statistic, or page/view which has the benefit of keeping all page specific APIs under the same dull, unsurprising path segment, page/.
Change 293179 had a related patch set uploaded (by Niedzielski):
Add most read models and unmarshaller tests
Change 293462 had a related patch set uploaded (by Niedzielski):
Add most read Feed data client and test
Change 293572 had a related patch set uploaded (by Niedzielski):
Regenerate test JSON
Change 294376 had a related patch set uploaded (by Niedzielski):
Add Retrofit service cache
Change 294395 had a related patch set uploaded (by Niedzielski):
Apply variant C most read UI tweaks