Page MenuHomePhabricator
Create Task
Maniphest T131337

MobileFrontendSkinHooks::gradeCImageSupport() should not apply to Vector skin output
Closed, ResolvedPublic
Actions

Description

My account has MobileFrontend beta enabled and when browsing on https://en.wikipedia.org/wiki/Main_Page (desktop site), the window.NORLQ section for MobileFrontendSkinHooks::gradeCImageSupport() is being included, which seems unrelated to the Vector skin and Desktop mode as the actual functionality this relates to is only enabled in Mobile context (currently Minerva skin).

It should probably use MobileContext::shouldDisplayMobileView() or a similar conditional.

Details

SubjectRepoBranchLines +/-
Do not load mobile JS in desktopmediawiki/extensions/MobileFrontendwmf/1.27.0-wmf.19+3 -1
Do not load mobile JS in desktopmediawiki/extensions/MobileFrontendmaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Mar 31 2016, 5:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2016, 5:06 AM
dr0ptp4kt triaged this task as High priority.Mar 31 2016, 5:13 PM
dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.
• bmansurov claimed this task.Mar 31 2016, 7:18 PM
• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.
gerritbot subscribed.Mar 31 2016, 7:29 PM

Change 280709 had a related patch set uploaded (by Bmansurov):
Do not load mobile JS in desktop

https://gerrit.wikimedia.org/r/280709

gerritbot added a project: Patch-For-Review.Mar 31 2016, 7:29 PM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Mar 31 2016, 7:30 PM
• bmansurov removed • bmansurov as the assignee of this task.Mar 31 2016, 7:42 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.
• bmansurov subscribed.
gerritbot added a comment.Mar 31 2016, 8:03 PM

Change 280709 merged by jenkins-bot:
Do not load mobile JS in desktop

https://gerrit.wikimedia.org/r/280709

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Mar 31 2016, 9:00 PM
gerritbot added a comment.Apr 1 2016, 7:57 PM

Change 280967 had a related patch set uploaded (by Krinkle):
Do not load mobile JS in desktop

https://gerrit.wikimedia.org/r/280967

gerritbot added a comment.Apr 1 2016, 10:54 PM

Change 280967 merged by jenkins-bot:
Do not load mobile JS in desktop

https://gerrit.wikimedia.org/r/280967

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Apr 1 2016, 11:00 PM
Stashbot subscribed.Apr 1 2016, 11:43 PM

Mentioned in SAL [2016-04-01T23:43:50Z] <krinkle@tin> Synchronized php-1.27.0-wmf.19/extensions/MobileFrontend/includes/MobileFrontend.hooks.php: T131337 (duration: 00m 38s)

Krinkle closed this task as Resolved.Apr 1 2016, 11:45 PM
Krinkle claimed this task.
• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay board.Apr 11 2016, 10:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL