Page MenuHomePhabricator
Create Task
Maniphest T133409

Complete initial version of TemplateStyles sufficient to do security review and then deploy it to WMF production
Closed, ResolvedPublic
Actions

Description

What's left to do?

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
 ResolvedJdlrobsonT186627 Remove the MobileView API
 DeclinedNoneT173379 Remove mobileview API call for main page
 DuplicateNoneT172525 [EPIC] Deprecate MobileView API in MobileFrontend
 ResolvedJdlrobsonT32405 [EPIC] MobileFrontend extension should stop special-casing main page
 DuplicateNoneT138449 Throw warning when edits made to a main page which uses special casing
 DuplicateNoneT138622 Help community migrate away from legacy Main page special casing
 DeclinedNoneT125920 [EPIC] Future exciting reading web performance endeavours
 ResolvedJdlrobsonT131423 FOUC in section "Recently featured" on mobile Main Page
 DuplicateNoneT126137 FOUC for styles applied via MediaWiki:Mobile.css due to bottom-loading
 DuplicateNoneT130846 Hat-note FOUC on mobile skin
 ResolvedNoneT51440 MobileFrontend images shown double-sized in Retina desktop, iOS 7 beta
 OpenNoneT40848 Security: CSS positioning can be used to break out of the content area
 OpenNoneT37704 Drop support in wikitext for inline styles
 ResolvedTheDJT151170 Varying layouts for commons mobile main page
 DeclinedNoneT125257 Infoboxes should take the max. available width of the screen
 InvalidNoneT135857 Map points aligned to viewport on mobile
 OpenFeatureNoneT17075 Per book, category and/or template CSS and JavaScript
 InvalidNoneT109152 [EPIC] All templates on wiki should work in mobile
 ResolvedTheDJT94107 {{hat}} and similar templates on Wikipedia are invisible to mobile web view.
 ResolvedTheDJT118062 In the mobile frontend, in the list produced by Template:Notelist-ua, efn-ua footnotes appear with numeric labels instead of uppercase-alpha. They appear normal in the text, and in the desktop frontend.
 InvalidNoneT120238 Wrong display of certain English Wikipedia portal pages in mobile
 ResolvedIznoT127727 navigational sidebar on mobile, should float on wide screens.
 ResolvedTheDJT128095 Signpost is not readable on mobile devices
 OpenNoneT117950 Remove the need for `.noprint`
 ResolvedJdlrobsonT117951 Remove templaters' need for .nomobile and support authoring media queries for templates
 OpenovasilevaT66577 Large tables created by editors are not responsive
 DeclinedNoneT66578 Migrate css rules in hacks.less into templates
 ResolvedTgrT133410 Deploy TemplateStyles to WMF production
 ResolvedAnomieT133414 Deploy TemplateStyles to the beta-cluster
 ResolvedtstarlingT133408 Security review of TemplateStyles
 ResolvedcorenT133409 Complete initial version of TemplateStyles sufficient to do security review and then deploy it to WMF production

Event Timeline

Jdforrester-WMF created this task.Apr 22 2016, 5:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 22 2016, 5:43 PM
Jdforrester-WMF renamed this task from Complete initial version of TemplateStyles sufficient to deploy it to WMF production to Complete initial version of TemplateStyles sufficient to do security review and then deploy it to WMF production.Apr 22 2016, 5:44 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: Epic.
Jdforrester-WMF added a subtask: T133408: Security review of TemplateStyles.
Jdforrester-WMF removed a subtask: T133408: Security review of TemplateStyles.Apr 22 2016, 5:49 PM
Jdforrester-WMF added a parent task: T133408: Security review of TemplateStyles.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a subscriber: coren.
coren added a comment.Apr 23 2016, 1:52 PM

What's left to do?

I think most of what's left lies in the security review:

  • Determine whether the current list of blacklisted properties suffices
  • Determine if more functional values should be whitelisted
  • Try to style things that shouldn't be styled
    • Fix any found holes and add tests for them

The actual functionality of the extension is complete - at least to the current specs. The <templatestyles> tag is implemented and properly supplies styling to pages transcluding them provided they are in the list of acceptable namespaces.

Jdforrester-WMF closed this task as Resolved.Apr 25 2016, 5:40 PM
Jdforrester-WMF assigned this task to coren.

OK, let's move determining the policy up to the security review.

• ggellerman moved this task from Backlog to Done on the TemplateStyles board.Nov 21 2017, 7:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL