Page MenuHomePhabricator
Create Task
Maniphest T134772

Update NavigationTiming to reflect when lazy loaded images in force
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

As a data analyst, I want NavigationTiming event logging to reflect when by MediaWiki server configuration lazy loaded images are in force.

Presently, NavigationTiming code looks for a cookie (related code: Navigation Timing extension, Varnish VCL for cache split), but when the configuration is not cookie driven (i.e., when the markup and JavaScript are on by default) I want to ensure that events in the event logging table are reflective of as much.

  • Update cookie to use mw.config (no changes in schema needed)

Related Objects
Search...

Event Timeline

dr0ptp4kt created this task.May 9 2016, 3:22 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 9 2016, 3:22 PM
dr0ptp4kt added a project: Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 9 2016, 3:22 PM
dr0ptp4kt added a parent task: T134003: Deploy lazy loaded images to a few more wikis.
Krenair added a project: NavigationTiming.May 9 2016, 3:59 PM
Jdlrobson updated the task description. (Show Details)May 9 2016, 4:35 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 9 2016, 4:38 PM
Jdlrobson set the point value for this task to 0.5.
Jdlrobson claimed this task.May 9 2016, 5:57 PM
Jdlrobson moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.
gerritbot subscribed.May 9 2016, 6:05 PM

Change 287671 had a related patch set uploaded (by Jdlrobson):
Use config variable rather than cookie

https://gerrit.wikimedia.org/r/287671

gerritbot added a project: Patch-For-Review.May 9 2016, 6:05 PM
Jdlrobson moved this task from Blocked Externally to -1 (Needs More Work) on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 9 2016, 6:05 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.
• Tbayer subscribed.May 9 2016, 9:33 PM
gerritbot added a comment.May 10 2016, 2:23 PM

Change 287671 merged by jenkins-bot:
Use config variable rather than cookie

https://gerrit.wikimedia.org/r/287671

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 3:00 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 10 2016, 4:12 PM
gerritbot added a comment.May 10 2016, 5:57 PM

Change 288008 had a related patch set uploaded (by Jdlrobson):
Use config variable rather than cookie

https://gerrit.wikimedia.org/r/288008

gerritbot added a comment.May 10 2016, 5:57 PM

Change 288008 abandoned by Jdlrobson:
Use config variable rather than cookie

Reason:
Ignore me

https://gerrit.wikimedia.org/r/288008

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 10 2016, 5:57 PM
Jdlrobson moved this task from Done to Ready for Signoff on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.
Jdlrobson removed a project: Patch-For-Review.
phuedx reassigned this task from Jdlrobson to dr0ptp4kt.May 12 2016, 9:06 AM
phuedx added a subscriber: Jdlrobson.
phuedx subscribed.

Over to you @dr0ptp4kt.

Jdlrobson changed the task status from Open to Stalled.May 12 2016, 4:56 PM
Jdlrobson claimed this task.

I'd like to check this in production which is stalled on this patch making it to Bengali Wikipedia (on 17th)

dr0ptp4kt added a comment.May 12 2016, 5:00 PM

Do you mean the 19th?

Jdlrobson closed this task as Resolved.May 17 2016, 6:48 PM

This is working. I see entries where the flag is 'A' for Bengali wiki stable and when not Bengali wiki beta (since all betas are opted in)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL