Page MenuHomePhabricator
Create Task
Maniphest T138792

[Subtask] Lazy loading references does not work on reference sections with subsections
Closed, ResolvedPublic
Actions

Description

A section can have multiple elements in it.
http://reading-web-staging.wmflabs.org/wiki/Referendum?mobileaction=beta
Expected: Click reference section and view the lazy loaded references section
Actual: The section fails to load.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 Resolveddr0ptp4ktT114542 Next Generation Content Loading and Routing, in Practice
 Duplicate• JhernandezT104432 [EPIC]: Improve mobile site performance
 Duplicatedr0ptp4ktT120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
 DeclinedNoneT125920 [EPIC] Future exciting reading web performance endeavours
 ResolvedJdlrobsonT113066 [GOAL] Make Wikipedia more accessible to 2G connections
 DeclinedNoneT123328 [GOAL] Lazy load references in mobile skin
 DuplicateNoneT137154 Deploy lazy loaded images to tl.m.wikipedia.org
 ResolvedJdlrobsonT136731 Deploy lazy loaded images, lazy loaded images + references to a couple larger wikis
 ResolvedphuedxT137822 Deploy lazy loaded images and references to tl.m.wikipedia.org
 Resolved• JhernandezT135539 Lazy loaded references in articles with JS for users who want to view the entire references section
 ResolvedJdlrobsonT138792 [Subtask] Lazy loading references does not work on reference sections with subsections

Event Timeline

Jdlrobson created this task.Jun 27 2016, 9:55 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 27 2016, 10:01 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Jun 27 2016, 10:07 PM

Doh.
Looks like we forgot that a reference section can have subheadings.
So in the example in the description the API returns two sections when all we actually want is the overall section.
This is a pain.
I propose:

  • we enrich mf-lazy-references-placeholder with the section id (if we can) so the id is easy to lookup.
  • A click to references would then show the spinner, replace all the mf-lazy-references-placeholder's and then hide the spinner.
Jdlrobson updated the task description. (Show Details)Jun 27 2016, 10:59 PM
Jdlrobson claimed this task.Jun 27 2016, 11:09 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 27 2016, 11:22 PM
gerritbot added a comment.Jun 27 2016, 11:47 PM

Change 296355 had a related patch set uploaded (by Jdlrobson):
Load all reference lists inside a reference section

https://gerrit.wikimedia.org/r/296355

gerritbot added a project: Patch-For-Review.Jun 27 2016, 11:47 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 27 2016, 11:47 PM

I've found a fix and added a test but have kept them separate in case we want to refactor the test.

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 28 2016, 11:58 AM
Jdlrobson added a comment.Jun 28 2016, 7:09 PM

This is blocked on @bmansurov following up my comment.

• bmansurov added a comment.Jun 29 2016, 1:51 AM

Ah, I should have provided more info. Please see the patch for the link to a test page and screenshots.

• Jhernandez added a comment.Jun 29 2016, 10:34 AM

I've tested it too, didn't work for me. Posted source and gif on patch.

• Jhernandez moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Jun 29 2016, 5:14 PM
MBinder_WMF renamed this task from Lazy loading references does not work on reference sections with subsections to [Subtask] Lazy loading references does not work on reference sections with subsections.Jun 29 2016, 5:36 PM
MBinder_WMF removed a project: Unplanned-Sprint-Work.
MBinder_WMF subscribed.

Removing "Uplanned-Sprint-Work" since this is a subtask of a previously-planned task in the sprint.

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 29 2016, 6:24 PM
• Jhernandez moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 30 2016, 10:55 AM

I've merged the fix patch, but the follow-up tests patch needs work. Moving to signoff to verify the feature works.

Please don't resolve until the unit tests patch is merged.

• Jhernandez added a comment.Jun 30 2016, 11:02 AM

If signed off, resolve T135539 (parent task) and move T137822 (deployment task, parent of parent) forward (ping somebody on a comment for example)

• bmansurov moved this task from Ready for Signoff to -1 (Needs More Work) on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 30 2016, 12:43 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 30 2016, 5:04 PM

Although @Jhernandez merged this, it failed to merge due to a jsdoc error (fixed) @bmansurov found an issue on my task however which I've also fixed.

• jhobs moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 30 2016, 6:07 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 30 2016, 6:42 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 30 2016, 10:35 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jun 30 2016, 11:06 PM
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jul 4 2016, 5:52 AM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jul 4 2016, 5:39 PM
gerritbot added a comment.Jul 5 2016, 7:25 AM

Change 296355 merged by jenkins-bot:
Load all reference lists inside a reference section

https://gerrit.wikimedia.org/r/296355

• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-75-Quantitative-Paralysis board.Jul 5 2016, 7:29 AM
• bmansurov closed this task as Resolved.Jul 5 2016, 7:32 AM

Please visit http://en.m.wikipedia.beta.wmflabs.org/wiki/NestedRefs?mobileaction=beta to test the fix.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jul 5 2016, 8:00 AM
• Phabricator_maintenance moved this task from 2015-16 Q4 to 2016-17 Q1 on the Web-Team-Backlog board.Mar 6 2018, 11:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL