Maniphest T146568

Add a primary key to oldimage
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	• Tjlsangria
	Sep 25 2016, 7:25 AM

Tags

Referenced Files

None

Subscribers

Description

oldimage doesn't have a primary key; see T17441.

Details

	Subject	Repo	Branch	Lines +/-
	Add primary key to oldimage	mediawiki/core	master	+60 -0

Customize query in gerrit

Related Objects

Mentioned In: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data
T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys)
Mentioned Here: T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys)
T17441: Some tables lack unique or primary keys, may allow confusing duplicate data

Event Timeline

• Tjlsangria created this task.Sep 25 2016, 7:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2016, 7:25 AM

• Tjlsangria added a project: MediaWiki-libs-Rdbms.Sep 25 2016, 7:25 AM

Peachey88 added a project: Schema-change.Sep 25 2016, 7:25 AM

Krenair added a parent task: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.Sep 25 2016, 11:00 AM

Change 318547 had a related patch set uploaded (by Paladox):
Add primary key to oldimage

https://gerrit.wikimedia.org/r/318547

gerritbot added a project: Patch-For-Review.Oct 28 2016, 2:11 PM

Paladox subscribed.Oct 28 2016, 2:27 PM

Marostegui subscribed.Mar 29 2017, 6:42 AM

Reedy moved this task from Unsorted to Add / Create on the Schema-change board.Apr 26 2017, 2:22 PM

Krinkle moved this task from Untriaged to Schema changes on the MediaWiki-libs-Rdbms board.May 8 2017, 1:27 AM

Change 318547 abandoned by Paladox:
Add primary key to oldimage

https://gerrit.wikimedia.org/r/318547

oldimage is probably going away... This doesn't seem important to get done anytime soon. See T28741 for more info

Reedy mentioned this in T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).Aug 29 2017, 10:00 PM

Krinkle added a parent task: T6715: Allow comments longer than 255 bytes.Apr 3 2018, 3:44 PM

Reedy mentioned this in T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.Jul 11 2018, 8:29 PM

MGChecker added a project: MediaWiki-Comment-store.Nov 12 2018, 7:45 PM

Krinkle closed this task as a duplicate of T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).Feb 8 2019, 6:35 PM

Krinkle removed parent tasks: T6715: Allow comments longer than 255 bytes, T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.