Page MenuHomePhabricator
Create Task
Maniphest T149413

Don't show error and CTA boxes together on login/accountcreate forms when in an error state
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Go to the login form and try to login with a bad user/password combo.

Expected: The gray box shouldn't show and the error box should.
Actual: Both are showing

Screen Shot 2016-10-28 at 11.01.06 AM.png (690×998 px, 64 KB)

This didn't happen before. When designing we purposely wanted to only show the CTA to people at the beginning of the workflow. We should add a test and fix this.

AC

  • When the user navigates to the login form, they should see the CTA.
  • Hide welcome message for all failed POST requests on login form
  • should work the same on createaccount form

Details

SubjectRepoBranchLines +/-
Do not show warning box when LoginForm was postedmediawiki/skins/MinervaNeuemaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Oct 28 2016, 10:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2016, 10:02 AM
ovasileva triaged this task as High priority.Nov 1 2016, 2:58 PM
ovasileva lowered the priority of this task from High to Medium.Nov 2 2016, 7:49 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson removed a project: Web-Team-Backlog.Apr 13 2017, 9:22 PM
Jdlrobson added a subscriber: • Nirzar.

@Nirzar thoughts? Is the description as written correct?

Jdlrobson added a project: Web-Team-Backlog.Apr 13 2017, 10:48 PM
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson assigned this task to • Nirzar.Apr 20 2017, 7:10 PM
Jdlrobson moved this task from Needs Prioritization to Product Owner Backlog on the Web-Team-Backlog board.May 26 2017, 7:28 PM
Jdlrobson moved this task from Product Owner Backlog to Design on the Web-Team-Backlog board.
Jdlrobson edited projects, added Web-Team-Backlog (Design); removed Web-Team-Backlog.
• Nirzar added a comment.EditedJun 27 2017, 11:38 PM

Yes this is correct. Show only the error message

Bonus:
We did lot of work around input field state management. Error states was a big part of it. Idk if MediaWiki UI has error states in it. in OOJS UI we turn the border of the error field red.

error.png (1×750 px, 103 KB)

If we can actually show where the error is, that helps the user enormously

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).Jun 27 2017, 11:50 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson added a subscriber: Volker_E.

If we can actually show where the error is, that helps enormously for the user.

Agreed. I'm not sure if this is on @Volker_E radar but we'd need to OOjs-ui-ify the login form... tracked in T85853 ?

• Nirzar added a comment.Jun 27 2017, 11:53 PM

sound good!

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jun 28 2017, 6:00 PM
phuedx renamed this task from We show error and cta boxes together on login form to Don't show error and CTA boxes together on login form when in an error state.Jul 5 2017, 10:51 AM
phuedx updated the task description. (Show Details)
phuedx updated the task description. (Show Details)
ovasileva set the point value for this task to 2.Jul 5 2017, 4:15 PM
ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Jul 11 2017, 6:21 PM
ovasileva moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.
ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 12 2017, 5:27 PM
ovasileva moved this task from 2016-17 Q4 to 2017-18 Q1 on the Web-Team-Backlog board.Jul 13 2017, 5:40 PM
pmiazga claimed this task.Jul 14 2017, 6:11 PM
pmiazga moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.
gerritbot subscribed.Jul 17 2017, 10:57 PM

Change 365871 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Do not show warning box when LoginForm was posted

https://gerrit.wikimedia.org/r/365871

gerritbot added a project: Patch-For-Review.Jul 17 2017, 10:57 PM
pmiazga added a comment.EditedJul 17 2017, 11:03 PM

As it's pretty difficult to detect failed login form I decided to not show the message when a user sends POST request. This should do the trick valid POST request will redirect to a different page, only bad POST request will cause two boxes to be visible.

@Nirzar - Special:CreateAccount page had same logic (same warning box was always visible). I decided to be consistent and do same behavior both on LoginPage and CreateAccount. When user form is invalid we will present only form error without gray box. If you agree with it please update task description to include both Login and CreateAccount pages.

pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 17 2017, 11:04 PM
pmiazga edited projects, added MinervaNeue; removed MobileFrontend.
• Nirzar updated the task description. (Show Details)Jul 17 2017, 11:05 PM

@pmiazga works for me. desc updated

pmiazga renamed this task from Don't show error and CTA boxes together on login form when in an error state to Don't show error and CTA boxes together on login/accountcreate forms when in an error state.Jul 18 2017, 3:20 PM
pmiazga updated the task description. (Show Details)
Jdlrobson mentioned this in T170880: Parser tests fail if default Skin for unit tests makes use of doEditSectionLink.Jul 18 2017, 6:26 PM
Jdlrobson moved this task from Needs Code Review to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.

Review is blocked by T170880

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.Jul 18 2017, 6:45 PM
gerritbot added a comment.Jul 19 2017, 5:44 PM

Change 365871 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Do not show warning box when LoginForm was posted

https://gerrit.wikimedia.org/r/365871

Jdlrobson moved this task from Blocked on Others to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Jul 19 2017, 5:48 PM
Jdlrobson removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Jul 19 2017, 6:00 PM
ovasileva reassigned this task from pmiazga to ABorbaWMF.Jul 20 2017, 12:41 PM
ovasileva added subscribers: ABorbaWMF, pmiazga, ovasileva.

over to you @ABorbaWMF! testing criteria is in the task decription

ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jul 21 2017, 6:37 PM

Tested on the beta cluster on android and ios devices. Everything looks good.

phuedx reassigned this task from ABorbaWMF to ovasileva.Jul 24 2017, 12:58 PM
phuedx subscribed.

Per T149413#3461479.

ovasileva closed this task as Resolved.Jul 24 2017, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL